Skip to content

linker feature System.TimeZoneInfo.Invariant #45792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 23, 2025
Merged

linker feature System.TimeZoneInfo.Invariant #45792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2cc7c31
System.TimeZoneInfo.Invariant feature
pavelsavara Jan 8, 2025
d7fce1f
Merge branch 'main' into trim_timezones
pavelsavara Jan 8, 2025
0e29af8
fix test
pavelsavara Jan 8, 2025
a850504
Merge branch 'main' into trim_timezones
pavelsavara Jan 9, 2025
2114dbd
Merge branch 'main' into trim_timezones
pavelsavara Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Containers/Microsoft.NET.Build.Containers/KnownStrings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public static class Properties
public static readonly string PublishTrimmed = nameof(PublishTrimmed);
public static readonly string PublishSelfContained = nameof(PublishSelfContained);
public static readonly string InvariantGlobalization = nameof(InvariantGlobalization);
public static readonly string InvariantTimezone = nameof(InvariantTimezone);
}

public static class Items
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,11 @@ Copyright (c) .NET Foundation. All rights reserved.
Value="$(InvariantGlobalization)"
Trim="true" />

<RuntimeHostConfigurationOption Include="System.TimeZoneInfo.Invariant"
Condition="'$(InvariantTimezone)' != ''"
Value="$(InvariantTimezone)"
Trim="true" />

<RuntimeHostConfigurationOption Include="System.Globalization.Hybrid"
Condition="'$(HybridGlobalization)' != ''"
Value="$(HybridGlobalization)"
Expand Down
1 change: 1 addition & 0 deletions test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAProjectWithAllFeatures.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ public void It_publishes_the_project_correctly(string targetFramework, string[]
""System.Diagnostics.Tracing.EventSource.IsSupported"": false,
""System.Drawing.Design.UITypeEditor.IsSupported"": true,
""System.Globalization.Invariant"": true,
""System.TimeZoneInfo.Invariant"": true,
""System.Globalization.PredefinedCulturesOnly"": true,
""System.GC.Concurrent"": false,
""System.GC.Server"": true,
Expand Down
1 change: 1 addition & 0 deletions test/TestAssets/TestProjects/KitchenSink/TestApp/TestApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
<EventSourceSupport>false</EventSourceSupport>
<_WinFormsUITypeEditorSupport>true</_WinFormsUITypeEditorSupport>
<InvariantGlobalization>true</InvariantGlobalization>
<InvariantTimezone>true</InvariantTimezone>
<PredefinedCulturesOnly>true</PredefinedCulturesOnly>
<ConcurrentGarbageCollection>false</ConcurrentGarbageCollection>
<ServerGarbageCollection>true</ServerGarbageCollection>
Expand Down
Loading