Skip to content

Do not show VS workloads from an old version Fixes #47794#47809

Merged
Forgind merged 1 commit intodotnet:release/9.0.3xxfrom
Forgind:verify-workloads-from-version
Mar 25, 2025
Merged

Do not show VS workloads from an old version Fixes #47794#47809
Forgind merged 1 commit intodotnet:release/9.0.3xxfrom
Forgind:verify-workloads-from-version

Conversation

@Forgind
Copy link
Copy Markdown
Contributor

@Forgind Forgind commented Mar 22, 2025

Fixes #47794

I ported the changes over to main for actual testing, hence this being targeted at 9.0.3xx but mentioning a 10.0- feature band.

Without the change:

Workload version: 10.0.100-manifests.7ab2c471

Installed Workload Id      Manifest Version                                 Installation Source
-----------------------------------------------------------------------------------------------
android                    35.99.0-preview.1.140/10.0.100-preview.1         VS 17.14.35824.293
aspire                     8.2.2/8.0.100                                    VS 17.14.35824.293
ios                        18.2.10322-net10-p1/10.0.100-preview.1           VS 17.14.35824.293
maccatalyst                18.2.10322-net10-p1/10.0.100-preview.1           VS 17.14.35824.293
macos                      15.2.10322-net10-p1/10.0.100-preview.1           VS 17.14.35824.293
maui-windows               10.0.0-preview.1.25122.6/10.0.100-preview.1      VS 17.14.35824.293
tvos                       18.2.10322-net10-p1/10.0.100-preview.1           VS 17.14.35824.293
wasm-tools                 10.0.0-preview.4.25170.5/10.0.100-preview.4      VS 17.14.35824.293
wasm-tools-net6            10.0.0-preview.4.25170.5/10.0.100-preview.4      VS 17.14.35824.293
wasm-tools-net7            10.0.0-preview.4.25170.5/10.0.100-preview.4      VS 17.14.35824.293
wasm-tools-net8            10.0.0-preview.4.25170.5/10.0.100-preview.4      VS 17.14.35824.293

Use `dotnet workload search` to find additional workloads to install.

With the change:

Installed Workload Id      Manifest Version      Installation Source
--------------------------------------------------------------------

Use `dotnet workload search` to find additional workloads to install.

(I hadn't installed any workloads at that point, so empty is correct.)

I then installed wasm-tools and ran it again and got this result:

Installed Workload Id      Manifest Version                                 Installation Source
-----------------------------------------------------------------------------------------------
wasm-tools                 10.0.0-preview.3.25167.9/10.0.100-preview.3      SDK 10.0.100

Use `dotnet workload search` to find additional workloads to install.

/cc: @danroth27

@nagilson
Copy link
Copy Markdown
Member

I was concerned this would break workload install for VS with certain situations or workload clean but I think this code is isolated to info and list.

@nagilson
Copy link
Copy Markdown
Member

nagilson commented Mar 25, 2025

Note that I believe this change will also impact workload info, I'm not sure if you also want that to not show the other VS Workloads.

@Forgind Forgind merged commit 2b56e8d into dotnet:release/9.0.3xx Mar 25, 2025
33 checks passed
@Forgind Forgind deleted the verify-workloads-from-version branch March 25, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Workloads untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants