Do not show VS workloads from an old version Fixes #47794#47809
Merged
Forgind merged 1 commit intodotnet:release/9.0.3xxfrom Mar 25, 2025
Merged
Do not show VS workloads from an old version Fixes #47794#47809Forgind merged 1 commit intodotnet:release/9.0.3xxfrom
Forgind merged 1 commit intodotnet:release/9.0.3xxfrom
Conversation
3 tasks
nagilson
approved these changes
Mar 25, 2025
Member
|
I was concerned this would break workload install for VS with certain situations or workload clean but I think this code is isolated to info and list. |
Member
|
Note that I believe this change will also impact workload info, I'm not sure if you also want that to not show the other VS Workloads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47794
I ported the changes over to main for actual testing, hence this being targeted at 9.0.3xx but mentioning a 10.0- feature band.
Without the change:
With the change:
(I hadn't installed any workloads at that point, so empty is correct.)
I then installed wasm-tools and ran it again and got this result:
/cc: @danroth27