[main] Update dependencies from dotnet/windowsdesktop #47992

dotnet-maestro · 2025-03-28T19:42:00Z

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.NET.Sdk.WindowsDesktop: from 10.0.0-preview.4.25177.1 to 10.0.0-preview.4.25178.3 (parent: Microsoft.WindowsDesktop.App.Ref)
- Microsoft.Dotnet.WinForms.ProjectTemplates: from 10.0.0-preview.4.25174.6 to 10.0.0-preview.4.25177.2 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
- Microsoft.DotNet.Wpf.ProjectTemplates: from 10.0.0-preview.4.25177.1 to 10.0.0-preview.4.25178.3 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)

From https://github.com/dotnet/windowsdesktop

Subscription: 43b77b68-0b3c-49dd-3915-08d8e9750bf8
Build: 20250329.1
Date Produced: March 30, 2025 5:31:53 AM UTC
Commit: 8c1790a883361a09db2145842a5b0780bfe702bf
Branch: refs/heads/main

Updates:
- Microsoft.WindowsDesktop.App.Ref: from 10.0.0-preview.4.25177.2 to 10.0.0-preview.4.25179.1
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 10.0.0-preview.4.25177.2 to 10.0.0-preview.4.25179.1
- VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0: from 10.0.0-preview.4.25177.2 to 10.0.0-preview.4.25179.1
- VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0: from 10.0.0-preview.4.25177.2 to 10.0.0-preview.4.25179.1

…ld 20250328.1 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0 From Version 10.0.0-preview.4.25177.2 -> To Version 10.0.0-preview.4.25178.1 Dependency coherency updates Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates From Version 10.0.0-preview.4.25177.1 -> To Version 10.0.0-preview.4.25178.3 (parent: Microsoft.WindowsDesktop.App.Ref

dotnet-maestro · 2025-03-28T19:52:26Z

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

…ld 20250328.2 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0 From Version 10.0.0-preview.4.25177.2 -> To Version 10.0.0-preview.4.25178.2

…ld 20250329.1 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0 From Version 10.0.0-preview.4.25177.2 -> To Version 10.0.0-preview.4.25179.1

v-wuzhai · 2025-03-31T07:07:01Z

@dotnet/source-build @dotnet/product-construction PTAL

…-tests-in-VMR.patch

ViktorHofer · 2025-03-31T09:56:05Z

C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018: The "GenerateDepsFile" task failed unexpectedly. [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018: System.TypeInitializationException: The type initializer for 'System.Text.Encodings.Web.DefaultJavaScriptEncoder' threw an exception. ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=6.0.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    at System.ReadOnlySpan`1..ctor(T[] array) [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    at System.Text.Encodings.Web.DefaultJavaScriptEncoder..ctor(TextEncoderSettings settings, Boolean allowMinimalJsonEscaping) [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    at System.Text.Encodings.Web.DefaultJavaScriptEncoder..ctor(TextEncoderSettings settings) [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    at System.Text.Encodings.Web.DefaultJavaScriptEncoder..cctor() [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    --- End of inner exception stack trace --- [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    at System.Text.Encodings.Web.JavaScriptEncoder.get_UnsafeRelaxedJsonEscaping() [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    at Microsoft.Extensions.DependencyModel.DependencyContextWriter.Write(DependencyContext context, Stream stream) [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    at Microsoft.NET.Build.Tasks.GenerateDepsFile.WriteDepsFile(String depsFilePath) in //src/Tasks/Microsoft.NET.Build.Tasks/GenerateDepsFile.cs:line 254 [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    at Microsoft.NET.Build.Tasks.GenerateDepsFile.ExecuteCore() in //src/Tasks/Microsoft.NET.Build.Tasks/GenerateDepsFile.cs:line 297 [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    at Microsoft.NET.Build.Tasks.TaskBase.Execute() in /_/src/Tasks/Common/TaskBase.cs:line 45 [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Execute() [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]
C:\h\w\AEF40999\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [C:\h\w\AEF40999\t\dotnetSdkTests\5cn1nhcq.l20\It_checks_for---BC89084B\Dependency\Dependency.csproj::TargetFramework=netstandard1.5]

@carlossanlop some .NET Framework msbuild tests are failing because of the System.Runtime.CompilerServices.Unsafe/6.1.0 package update. In this case I bet that something is loading the newer CU assembly into a desktop msbuild task host. Can you please take a look?

Looks like this affects all PRs in dotnet/sdk. Presumably a PR with the failures got force merged.

ViktorHofer · 2025-03-31T10:09:48Z

Why are those PRs getting auto-merged with a failing job? That should be fixed asap. In this case it's fine because the regression already happened in #47898. cc @marcpopMSFT - probably BuildAnalysis related

premun · 2025-03-31T11:35:47Z

@ViktorHofer the dotnet-sdk-public-ci leg is not marked as Required in this repo's settings

ViktorHofer · 2025-03-31T11:39:19Z

Right. But IIRC the "Build Analysis" leg should be marked as required and check whether the dotnet-sdk-public-ci pipeline is green.

premun · 2025-03-31T11:42:38Z

Seems like BA is neutral until other checks fail:

So maybe UB + SB finished green and then it got merged without waiting for SDK CI as BA could not have gone red yet?

ViktorHofer · 2025-03-31T11:52:49Z

dotnet/dnceng#3327 is probably the tracking issue for this. cc @missymessa

marcpopMSFT · 2025-03-31T16:59:23Z

It was suggested we use BA is the primary check but that doesn't work because of 3327 and we were told not to allow people to override the check on sourcebuild/unified build so we landed with this compromise. I guess in the case where the public PR build is still running but the other builds have completed, we hit 3327 and things get merged.

Should I add the CI leg back and hold off using BA until that issue is resolved?

ViktorHofer · 2025-03-31T17:26:23Z

Based on PRs with failing tests getting merged, I would say yes. We need resolution on dotnet/dnceng#3327 and then decide if we can again gate auto-merge on the Build Analysis job. We had to disable auto-merge in runtime for that exact reason.

dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Mar 28, 2025

dotnet-maestro bot added 2 commits March 29, 2025 05:55

build-analysis bot mentioned this pull request Mar 31, 2025

Template engine tests hitting known parallelism issue in GetVisualStudioInstances #44878

Open

Delete src/SourceBuild/patches/winforms/0001-Condition-out-the-native…

c1995e8

…-tests-in-VMR.patch

ViktorHofer requested review from a team as code owners March 31, 2025 07:49

ViktorHofer approved these changes Mar 31, 2025

View reviewed changes

ViktorHofer enabled auto-merge (squash) March 31, 2025 07:51

Merge branch 'main' into darc-main-e3b7da1d-a1cb-414b-b610-a49c478868dd

77d3fa1

ViktorHofer merged commit 3fb7dd4 into main Mar 31, 2025
40 of 43 checks passed

ViktorHofer deleted the darc-main-e3b7da1d-a1cb-414b-b610-a49c478868dd branch March 31, 2025 10:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/windowsdesktop #47992

[main] Update dependencies from dotnet/windowsdesktop #47992

dotnet-maestro bot commented Mar 28, 2025 •

edited

Loading

dotnet-maestro bot commented Mar 28, 2025

v-wuzhai commented Mar 31, 2025

ViktorHofer commented Mar 31, 2025 •

edited

Loading

ViktorHofer commented Mar 31, 2025

premun commented Mar 31, 2025 •

edited

Loading

ViktorHofer commented Mar 31, 2025 •

edited

Loading

premun commented Mar 31, 2025

ViktorHofer commented Mar 31, 2025

marcpopMSFT commented Mar 31, 2025

ViktorHofer commented Mar 31, 2025

[main] Update dependencies from dotnet/windowsdesktop #47992

[main] Update dependencies from dotnet/windowsdesktop #47992

Conversation

dotnet-maestro bot commented Mar 28, 2025 • edited Loading

Coherency Updates

From https://github.com/dotnet/windowsdesktop

dotnet-maestro bot commented Mar 28, 2025

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

v-wuzhai commented Mar 31, 2025

ViktorHofer commented Mar 31, 2025 • edited Loading

ViktorHofer commented Mar 31, 2025

premun commented Mar 31, 2025 • edited Loading

ViktorHofer commented Mar 31, 2025 • edited Loading

premun commented Mar 31, 2025

ViktorHofer commented Mar 31, 2025

marcpopMSFT commented Mar 31, 2025

ViktorHofer commented Mar 31, 2025

dotnet-maestro bot commented Mar 28, 2025 •

edited

Loading

ViktorHofer commented Mar 31, 2025 •

edited

Loading

premun commented Mar 31, 2025 •

edited

Loading

ViktorHofer commented Mar 31, 2025 •

edited

Loading