Skip to content

[StaticWebAssets] Rename WriteImportMapToHtml to OverrideHtmlAssetPlaceholders #48312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 15, 2025
Merged

[StaticWebAssets] Rename WriteImportMapToHtml to OverrideHtmlAssetPlaceholders #48312

merged 5 commits into from
Apr 15, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 9, 2025

Contributes to dotnet/aspnetcore#60536

@maraf maraf added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Apr 9, 2025
@maraf maraf added this to the 10.0.1xx milestone Apr 9, 2025
@maraf maraf self-assigned this Apr 9, 2025
@ghost ghost added the untriaged Request triage from a team member label Apr 9, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @@maraf.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@maraf maraf removed the untriaged Request triage from a team member label Apr 9, 2025
@maraf maraf marked this pull request as ready for review April 14, 2025 12:35
@Copilot Copilot AI review requested due to automatic review settings April 14, 2025 12:35
@maraf maraf requested a review from a team as a code owner April 14, 2025 12:35
Copilot
Copilot AI reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets: Language not supported
  • src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.HtmlAssetPlaceholders.targets: Language not supported

@maraf maraf merged commit afb3494 into main Apr 15, 2025
39 checks passed
@maraf maraf deleted the maraf/WasmPlaceholderPropertyRename branch April 15, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ilonatommy ilonatommy ilonatommy approved these changes

Assignees

@maraf maraf

Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Milestone
10.0.1xx
Development

Successfully merging this pull request may close these issues.
2 participants
@maraf @ilonatommy