Skip to content

Re-Bootstrap Source Build to .NET 10.0.100-preview.4.25210.1 #48395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

Re-Bootstrap Source Build to .NET 10.0.100-preview.4.25210.1 #48395

merged 2 commits into from
Apr 14, 2025
+31 −7

Conversation

dotnet-sb-bot
Copy link
Contributor

@dotnet-sb-bot dotnet-sb-bot commented Apr 11, 2025 •
edited by ellahathaway
Loading

Re-Bootstrap Source Build to .NET 10.0.100-preview.4.25210.1

Closes dotnet/source-build#5041

@dotnet-sb-bot dotnet-sb-bot requested review from a team as code owners April 11, 2025 16:24
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Apr 11, 2025
@ellahathaway
Copy link
Member

@dotnet/product-construction - There's a UB failure: ##[error]src\aspnetcore\src\SignalR\clients\csharp\Http.Connections.Client\src\Microsoft.AspNetCore.Http.Connections.Client.csproj(0,0): error NU1510: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: PackageReference System.Net.ServerSentEvents will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary

Is this a known failure?

@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 11, 2025 •
edited
Loading

Upgrading to a newer SDK often comes with these kinds of new warnings. This will need reaction in aspnetcore. I can take a look.

In this case, ServerEvents moved inbox in NETCoreApp and therefore NuGet Package Pruning flags it as an unnecessary package reference in the consumption side.

ViktorHofer added a commit to dotnet/aspnetcore that referenced this pull request Apr 12, 2025
@ViktorHofer
Resolve NU1510 as System.Net.ServerSentEvents is inbox now
479ec30 
Unblocks dotnet/sdk#48395
@ViktorHofer ViktorHofer mentioned this pull request Apr 12, 2025
Merged
@build-analysis build-analysis bot mentioned this pull request Apr 12, 2025
Open
3 tasks
@ViktorHofer ViktorHofer enabled auto-merge (squash) April 13, 2025 08:12
ViktorHofer added a commit to dotnet/aspnetcore that referenced this pull request Apr 13, 2025
@ViktorHofer
Resolve NU1510 as System.Net.ServerSentEvents is inbox now (#61467)
06befe5 
Unblocks dotnet/sdk#48395
@ViktorHofer ViktorHofer disabled auto-merge April 14, 2025 07:06
@ViktorHofer
Copy link
Member

Force merge as the test failure is unrelated to the VMR re-boostrap.

@ViktorHofer ViktorHofer merged commit 9a813df into main Apr 14, 2025
36 of 39 checks passed
@ViktorHofer ViktorHofer deleted the apr2025-source-build-1744388502 branch April 14, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@ellahathaway ellahathaway ellahathaway approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UB Build Failure: infra - SignCheck timeout
3 participants
@dotnet-sb-bot @ellahathaway @ViktorHofer