Skip to content

Conversation

v-wuzhai
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Apr 25, 2025
Copy link
Contributor

Thanks for your PR, @@v-wuzhai.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@v-wuzhai
Copy link
Contributor Author

@dotnet/aspnet-blazor-eng After updating the baselines, there are still two failing tests. Could you take a look?

Expected endpointsByAssetFile[file] to contain 2 item(s), but found 1:
{
Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAssetEndpoint
{
AssetFile = "_framework/dotnet.js.br",
{
EndpointProperties = Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAssetEndpointProperty
{
Name = "integrity",
Value = "sha256-Yn9thAmczv9cw4zLFW0HPVmMkr9WDuCzwJnjBhC35ls="
}
},
ResponseHeaders = Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAssetEndpointResponseHeader
{
{
Name = "Accept-Ranges",
Value = "bytes"
},
Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAssetEndpointResponseHeader
{
Name = "Cache-Control",
Value = "no-cache"
},
Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAssetEndpointResponseHeader
{
Name = "Content-Encoding",
Value = "br"
},
Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAssetEndpointResponseHeader
{
Name = "Content-Length",
Value = "19030"
},
Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAssetEndpointResponseHeader
{
Name = "Content-Type",
Value = "text/javascript"
},
Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAssetEndpointResponseHeader
{
Name = "ETag",
Value = ""Yn9thAmczv9cw4zLFW0HPVmMkr9WDuCzwJnjBhC35ls=""
},
Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAssetEndpointResponseHeader
{
Name = "Last-Modified",
Value = "Fri, 25 Apr 2025 08:09:17 GMT"
},
Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAssetEndpointResponseHeader
{
Name = "Vary",
Value = "Content-Encoding"
}
},
Route = "_framework/dotnet.js.br",
Selectors = {empty}
}
}.

@v-wuzhai v-wuzhai marked this pull request as ready for review April 25, 2025 08:12
@Copilot Copilot AI review requested due to automatic review settings April 25, 2025 08:12
@v-wuzhai v-wuzhai requested a review from a team as a code owner April 25, 2025 08:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (13)
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/Build_DoesNotGenerateManifestJson_IncludesJSModulesOnBlazorBootJsonManifest.Build.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/Build_SatelliteAssembliesAreCopiedToBuildOutput.Build.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/JSModules_ManifestIncludesModuleTargetPaths.Build.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/JsModules_CanCustomizeBlazorInitialization.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/JsModules_CanHaveDifferentBuildAndPublishModules.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/JsModules_Hosted_CanCustomizeBlazorInitialization.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/Publish60Hosted_Works.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/Publish_DoesNotGenerateManifestJson_IncludesJSModulesOnBlazorBootJsonManifest.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/StaticWebAssets_BuildMinimal_Works.Build.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/StaticWebAssets_Build_Hosted_Works.Build.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/StaticWebAssets_PublishMinimal_Works.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/StaticWebAssets_Publish_DoesNotIncludeXmlDocumentationFiles_AsAssets.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/StaticWebAssets_Publish_Hosted_Works.Publish.staticwebassets.json: Language not supported

@v-wuzhai v-wuzhai requested review from marcpopMSFT and joeloff April 25, 2025 08:13
@maraf
Copy link
Member

maraf commented Apr 25, 2025

Related to #48663, but I dunno yet why the CI passed there. It requires dotnet/runtime#114953 which landed in #48685.

When I merged the #48663, the runtime dependency pointed at dotnet/runtime@8c3a2e1, but now it points to dotnet/dotnet@721dc7a, which has older runtime sources.

@marcpopMSFT
Copy link
Member

Per offline conversation, the next vmr build should have the fix for this so if we wait ~6 hours, that should happen automatically and hopefully we don't need this PR.

@akoeplinger
Copy link
Member

as expected the VMR bump fixed this, closing

@akoeplinger akoeplinger deleted the dev/Jason/Fix-razorsdk-tests branch April 27, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants