Respond to dnup feedback from prototype code review
#51446
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splits up `ReleaseManifest` into 3 pieces: - A. Downloading of .NET Archives - B. Accessing the release manifest & release manifest data structures - C. Parsing a 'channel' into a ReleaseVersion This is a better separation of responsibility and makes each class a far more reasonable size.
What we were doing was setting the AppContext data such that the HOSTFXR_PATH pointed to the installed root location. We don't need to do that, the hostfxr interop(ped) API already points to the dotnet root location within which we want to resolve the hostfxr.
verification should happen in the downloader which will probably be deferred to the release deployment library
dsplaisted
approved these changes
Nov 6, 2025
|
|
||
| private IEnumerable<Product> GetProductsInMajorOrMajorMinor(IEnumerable<Product> index, int major, int? minor = null) | ||
| { | ||
| var validProducts = index.Where(p => p.ProductVersion.StartsWith(minor is not null ? $"{major}.{minor}" : $"{major}.")); |
There was a problem hiding this comment.
Can we do this by checking a version object instead of checking if the string starts with something? I think we'll need to parse the version first but that would seem better to me.
Comment on lines
+164
to
+165
| /// <param name="isLts">True for LTS (Long-Term Support), false for STS (Standard-Term Support)</param> | ||
| /// <param name="mode">InstallComponent.SDK or InstallComponent.Runtime</param> |
There was a problem hiding this comment.
Looks like these doc comments are out of date.
| /// <summary> | ||
| /// Handles downloading and parsing .NET release manifests to find the correct installer/archive for a given installation. | ||
| /// </summary> | ||
| internal class DotnetArchiveDownloader(HttpClient httpClient) : IDisposable |
There was a problem hiding this comment.
Do we need the constructor that specifies an HttpClient? It doesn't look like we use that outside of the class, and there's no way to specify both an httpClient and a ReleaseManifest.
| }; | ||
|
|
||
| // Set user-agent to identify dnup in telemetry | ||
| client.DefaultRequestHeaders.UserAgent.ParseAdd("dnup-dotnet-installer"); |
There was a problem hiding this comment.
Should this be customizable via the library? We might want to differentiate between requests from dotnetup and the Aspire CLI for example.
| Directory.CreateDirectory(Path.GetDirectoryName(destinationPath)!); | ||
|
|
||
| // Try to get content length for progress reporting | ||
| long? totalBytes = await GetContentLengthAsync(downloadUrl); |
There was a problem hiding this comment.
I think this adds an extra HTTP request. Is there a reason to do this separately rather than get the value from the header of the request which actually downloads?
Comment on lines
+63
to
+65
| var args = DnupTestUtilities.BuildArguments(channel, testEnv.InstallPath, testEnv.ManifestPath); | ||
| (int exitCode, string output) = DnupTestUtilities.RunDnupProcess(args, captureOutput: true, workingDirectory: testEnv.TempRoot); | ||
| exitCode.Should().Be(0, $"dnup exited with code {exitCode}. Output:\n{output}"); |
There was a problem hiding this comment.
Nit: indentation seems wrong here.
Comment on lines
+124
to
+125
| (int exitCode, string firstInstallOutput) = DnupTestUtilities.RunDnupProcess(args, captureOutput: true, workingDirectory: testEnv.TempRoot); | ||
| exitCode.Should().Be(0, $"First installation failed with exit code {exitCode}. Output:\n{firstInstallOutput}"); |
Comment on lines
+139
to
+140
| (exitCode, string output) = DnupTestUtilities.RunDnupProcess(args, captureOutput: true, workingDirectory: testEnv.TempRoot); | ||
| exitCode.Should().Be(0, $"Second installation failed with exit code {exitCode}. Output:\n{output}"); |
Comment on lines
+91
to
+93
| using var process = new Process(); | ||
| string repoDotnet = Path.Combine(repoRoot, ".dotnet", DnupUtilities.GetDotnetExeName()); | ||
| process.StartInfo.FileName = File.Exists(repoDotnet) ? repoDotnet : DnupUtilities.GetDotnetExeName(); |
| process.StartInfo.CreateNoWindow = true; | ||
| process.StartInfo.RedirectStandardOutput = captureOutput; | ||
| process.StartInfo.RedirectStandardError = captureOutput; | ||
| process.StartInfo.WorkingDirectory = workingDirectory ?? Environment.CurrentDirectory; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remediate the issues discussed in #50988 to fix the prototype
dnupcode. It's not a complete review of all of that code, however. I have not reviewed the portion of the CLI and PATH manipulation, though that's not directly part of the library, so I think that will come later.