Broadcast encryption support #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niharikadutta
commented
Aug 11, 2020
|
Looks like this is still hanging intermittently. Can we merge #678 to see if that helps? |
imback82
reviewed
Sep 28, 2020
src/csharp/Microsoft.Spark.Worker/Processor/BroadcastVariableProcessor.cs
Outdated
Show resolved
Hide resolved
| throw new NotImplementedException( | ||
| "broadcastDecryptionServer is not implemented."); | ||
| var readBid = SerDe.ReadInt64(socket.InputStream); | ||
| Debug.Assert(bid == readBid); |
There was a problem hiding this comment.
Since we get the value from an external system, can we throw an exception instead of assert?
There was a problem hiding this comment.
Added an exception, please let me know if the wording makes sense, I wasn't completely sure how to frame it.
…ikadutta/spark into nidutta/BroadcastEncryptionSupport
suhsteve
reviewed
Sep 28, 2020
src/csharp/Microsoft.Spark.Worker/Processor/BroadcastVariableProcessor.cs
Outdated
Show resolved
Hide resolved
…rocessor.cs Co-authored-by: Steve Suh <[email protected]>
imback82
previously approved these changes
Sep 28, 2020
imback82
reviewed
Sep 28, 2020
src/csharp/Microsoft.Spark.Worker/Processor/BroadcastVariableProcessor.cs
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds encryption support for broadcast variables. #620