-
Notifications
You must be signed in to change notification settings - Fork 326
Spark 3.0 readiness part 2 #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
imback82
merged 40 commits into
dotnet:master
from
Niharikadutta:nidutta/spark3.0readiness_part2
Sep 14, 2020
Merged
Spark 3.0 readiness part 2 #649
imback82
merged 40 commits into
dotnet:master
from
Niharikadutta:nidutta/spark3.0readiness_part2
Sep 14, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging latest from master
imback82
reviewed
Sep 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for one nit comment, thanks @Niharikadutta!
src/csharp/Microsoft.Spark.E2ETest/IpcTests/Sql/FunctionsTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Terry Kim <[email protected]>
suhsteve
approved these changes
Sep 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
imback82
approved these changes
Sep 14, 2020
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for following APIs added in Spark 3.0:
Functions APIs
scala
/python
def xxhash64(cols: Column): Columnscala
def split(str: Column, pattern: String, limit: Int): Columnscala
/python
def overlay(src: Column, replace: Column, pos: Column, len: Column): Columnscala
def overlay(src: Column, replace: Column, pos: Column): Columnscala
def add_months(startDate: Column, numMonths: Column): Columnscala
def date_add(start: Column, days: Column): Columnscala
def date_sub(start: Column, days: Column): Columnscala
def schema_of_json(json: Column, options: java.util.Map[String, String]): Columnscala
/python
def map_entries(e: Column): Columnscala
/python
def from_csv(e: Column, schema: StructType, options: Map[String, String]): Columnscala
def from_csv(e: Column, schema: Column, options: java.util.Map[String, String]): Columnscala
def schema_of_csv(csv: String): Columnscala
def schema_of_csv(csv: Column): Columnscala
/python
def schema_of_csv(csv: Column, options: java.util.Map[String, String]): Columnscala
/python
def to_csv(e: Column, options: java.util.Map[String, String]): Columnscala
def to_csv(e: Column): Columnscala
def years(e: Column): Columnscala
def months(e: Column): Columnscala
def days(e: Column): Columnscala
def hours(e: Column): Columnscala
def bucket(numBuckets: Column, e: Column): Columnscala
def bucket(numBuckets: Int, e: Column): ColumnThis PR addresses part of #633