Add NGram #734
Merged
Add NGram #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
There was a problem hiding this comment.
Sorry for the delay in reviewing this PR, I have left some comments. Thanks @SARAVANA1501 !
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/NGramTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/NGramTests.cs
Outdated
Show resolved
Hide resolved
GoEddie
reviewed
Dec 4, 2020
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/NGramTests.cs
Outdated
Show resolved
Hide resolved
|
A few nits but otherwise LGTM. Thanks @SARAVANA1501 ! |
Co-authored-by: Niharika Dutta <[email protected]>
Co-authored-by: Niharika Dutta <[email protected]>
|
Hey @SARAVANA1501, a couple of comments left but looking good: https://github.com/dotnet/spark/pull/734/files#r530591665 If you need a hand with any of them let me know, always happy to help. ed |
imback82
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
LGTM, thanks @SARAVANA1501 (and @Niharikadutta / @GoEddie for review)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#381
Add NGram functionality to dotnet spark