Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the nuget and microsoft extensions packages #8864

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

marcpopMSFT
Copy link
Member

Problem

Tooling has identified old packages being downloaded during the build. They aren't used in the SDK itself but we should get clean on CG

@marcpopMSFT marcpopMSFT requested a review from a team as a code owner March 26, 2025 20:51
@marcpopMSFT
Copy link
Member Author

@dotnet/source-build I updated to the versions that the SDK is using for these packages. Do I have to add all of them to the version.details.xml now?

@mthalman
Copy link
Member

@dotnet/source-build I updated to the versions that the SDK is using for these packages. Do I have to add all of them to the version.details.xml now?

The NuGet prebuilts will need to be added to SBRP (in the 9.0 branch). The others can be added to the prebuilt baseline.

@Forgind
Copy link
Member

Forgind commented Apr 2, 2025

@dotnet/source-build I updated to the versions that the SDK is using for these packages. Do I have to add all of them to the version.details.xml now?

The NuGet prebuilts will need to be added to SBRP (in the 9.0 branch). The others can be added to the prebuilt baseline.

Did anyone do this?

@marcpopMSFT
Copy link
Member Author

@mthalman would adding them to the version.details.xml also work? I went ahead and added nuget here: dotnet/source-build-reference-packages#1216

The rest I should add to the prebuilt exclusion list?

@mthalman
Copy link
Member

mthalman commented Apr 7, 2025

@mthalman would adding them to the version.details.xml also work?

No, because the VMR isn't configured for the templating repo to depend on the nuget-client repo. So regardless of how version.details.xml is defined, there's no live version of nuget to flow in. That's why it needs to be defined in SBRP.

The rest I should add to the prebuilt exclusion list?

Yes

@marcpopMSFT
Copy link
Member Author

@mthalman ok, updated the SBRP version and added the prebuilt exclusions. Hopefully the source build leg passes. Why wasn't adding the runtime entries in version.details.xml enough to avoid the prebuilt exclusions?

@marcpopMSFT marcpopMSFT merged commit 7fa9bf9 into release/9.0.1xx Apr 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants