-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the nuget and microsoft extensions packages #8864
Conversation
@dotnet/source-build I updated to the versions that the SDK is using for these packages. Do I have to add all of them to the version.details.xml now? |
The NuGet prebuilts will need to be added to SBRP (in the 9.0 branch). The others can be added to the prebuilt baseline. |
Did anyone do this? |
@mthalman would adding them to the version.details.xml also work? I went ahead and added nuget here: dotnet/source-build-reference-packages#1216 The rest I should add to the prebuilt exclusion list? |
No, because the VMR isn't configured for the templating repo to depend on the nuget-client repo. So regardless of how version.details.xml is defined, there's no live version of nuget to flow in. That's why it needs to be defined in SBRP.
Yes |
@mthalman ok, updated the SBRP version and added the prebuilt exclusions. Hopefully the source build leg passes. Why wasn't adding the runtime entries in version.details.xml enough to avoid the prebuilt exclusions? |
Problem
Tooling has identified old packages being downloaded during the build. They aren't used in the SDK itself but we should get clean on CG