Handle restore on the server #8780
Draft
+20
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
force-pushed
the
restore_server_side
branch
from
94d8046 to
f88f252
Compare
RikkiGibson
reviewed
Nov 18, 2025
| languageServer.registerOnRequest(ProjectNeedsRestoreRequest.type, async (params) => { | ||
| let projectFilePaths = params.projectFilePaths; | ||
| if (getCSharpDevKit()) { | ||
| // Only restore '.cs' files (file-based apps) if CDK is loaded. |
Member
There was a problem hiding this comment.
really nice to delete this also.
RikkiGibson
reviewed
Nov 18, 2025
| showOutput: boolean | ||
| projectFiles: string[] | ||
| ): Promise<void> { | ||
| if (_restoreInProgress) { |
Member
There was a problem hiding this comment.
Now this tracks only restores initiated by the client. Parallel restores on different things are still permitted on the server side. Perhaps that is what we want? At least there doesn't seem to be a need to make a change to that in this PR.
Member
Author
There was a problem hiding this comment.
right. don't want really multiple manually initiated restores running at once. But server can run automatic restores for diff projects
dibarbet
added a commit
to dotnet/roslyn
that referenced
this pull request
Nov 19, 2025
Followup to the canonical misc changes. This PR has two parts ## Move server initiated restore entirely to server Previously restores initiated by the server had to call out to the client to setup the correct UI, which then called back to the server to run the restore, all using custom LSP requests. This wasn't ideal as it meant extra custom client side code and an extra server -> client -> server loop. Instead, we can utilize the standard LSP [server initiated work done progress](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#serverInitiatedProgress) API to display progress from the server on the client side. This means server initiated restores no longer need any custom client code, and the server can choose when to display a UI without a client code change. This did require a bit of complex code to handle either the server or client cancelling the request. Additionally, we still have custom requests for manually initiated restores from the client. ## Hide restore progress for canonical files Utilizing the above change, I modified the server behavior to not show any progress when restoring the canonical file. This is an internal server operation and does not need to be displayed client side (based on feedback it only causes confusion). CLient side change - dotnet/vscode-csharp#8780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.