Fix path retrieval for cordova-ios 8.x#964
Conversation
Update getXcodeProjectPath to support cordova-ios 8.x.
WalkthroughThe iOS helper's getXcodeProjectPath now computes both the legacy app-named Xcode project path and the Cordova iOS 8+ Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Script Caller
participant Helper as ios/helper.getXcodeProjectPath
participant FS as Filesystem
Caller->>Helper: request Xcode project path
Helper->>FS: check existence of "platforms/ios/App.xcodeproj/project.pbxproj"
alt new path exists
FS-->>Helper: exists
Helper-->>Caller: return new path
else new path missing
Helper->>FS: check existence of "platforms/ios/<AppName>.xcodeproj/project.pbxproj"
alt legacy path exists
FS-->>Helper: exists
Helper-->>Caller: return legacy path
else none found
FS-->>Helper: not found
Helper-->>Caller: return legacy path (as fallback) / or undefined
end
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
scripts/ios/helper.js(1 hunks)
🧰 Additional context used
🪛 Biome (2.1.2)
scripts/ios/helper.js
[error] 71-71: expected ( but instead found fs
Remove fs
(parse)
[error] 71-71: expected ) but instead found {
Remove {
(parse)
|
@dpa99c Anything holding this up from being committed and released? This is causing problems for anyone using iOS engine 8.x. |
Update getXcodeProjectPath to support cordova-ios 8.x.
PR Type
What kind of change does this PR introduce?
PR Checklist
Please check your PR fulfills the following requirements:
Bugfixes:
What is the purpose of this PR?
This plugin does not work with
cordova-ios8.x - this change should resolve that.Does this PR introduce a breaking change?
What testing has been done on the changes in the PR?
Verified the new path is used when it exists.
What testing has been done on existing functionality?
Verified the old path is used in cordova-ios 7.x
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.