Minor Heartbeat updates: catch more exceptions / log configuration / raise KafkaConfigurationError #2618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on start; raise KafkaConfigurationError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we dont log the heartbeat configuration anywhere, so adding to help with debugging.
Also updating config checks to warn if heartbeat is above recommended 1/3rd of session timeout.
Biggest change is to catch all
Exceptionin heartbeat thread run loop. RuntimeError may have been too limiting, and if we fail to catch an exception that stops the thread without settingself.failedthen we will never restart the heartbeat thread and will not be able to send any additional heartbeats -- and worse the error does not get logged and the user is not alerted.