Skip to content

fix: Add tests for KafkaAdminClient #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ricky512227 wants to merge 1 commit into from
Closed

fix: Add tests for KafkaAdminClient #2711

Ricky512227 wants to merge 1 commit into from

Conversation

@Ricky512227
Copy link

@Ricky512227 Ricky512227 commented Jan 7, 2026

Description

I need to add tests for the KafkaAdmin changes I made:

  1. Stop using broker-errors for client-side problems #1639
  2. Fix KafkaAdmin send to controller #1640
  3. Add group coordinator lookup #1641
  4. Fix describe groups #1642
  5. Add list consumer groups offsets #1643
  6. Set a clear default value for validate_only / include_synonyms #1645

I didn't have time yet to do tests... Given that the existing `KafkaAdminCli

Changes Made

  • code: Added helpful documentation

Fixes #1648

@Ricky512227 Ricky512227 closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tests for KafkaAdminClient

2 participants

@Ricky512227 @actions-user