fix: support markup syntaxes #16
Conversation
|
|
jaredLunde
changed the title
| @@ -55,7 +55,7 @@ pub fn format_text(file_path: &Path, input_text: &str, config: &Configuration) - | |||
| let printed = formatted.print()?; | |||
| printed.into_code() | |||
| } | |||
| Some("js" | "jsx" | "ts" | "tsx" | "cjs" | "mjs" | "cts" | "mts") => { | |||
| Some("js" | "jsx" | "ts" | "tsx" | "cjs" | "mjs" | "cts" | "mts" | "astro" | "svelte" | "vue") => { | |||
There was a problem hiding this comment.
The code below formats js files, so won't this cause errors to surface for these file types? Maybe adding a test to this PR might help demonstrate the fix?
There was a problem hiding this comment.
This line below determines the JS syntax from the file path:
let Ok(syntax) = JsFileSource::try_from(file_path) else {Which winds up here: https://github.com/biomejs/biome/blob/561b54c93625c9a83035562022af47237e6c00b2/crates/biome_js_syntax/src/file_source.rs#L300
There was a problem hiding this comment.
I'm down to add a test though : )
There was a problem hiding this comment.
Oh, interesting. For adding a test it would just be adding a file like this one: https://github.com/dprint/dprint-plugin-biome/blob/main/tests/specs/Json.txt (but making the top line have a .svelte extension) then running cargo test
There was a problem hiding this comment.
Also don't forget to add a thing for json and jsonc since it's fully supported in biome.
https://biomejs.dev/internals/language-support/
There was a problem hiding this comment.
dprint-plugin-biome/src/format_text.rs
Line 34 in 3bdc77b
Allows downstream packages like markup_fmt pass extensions for files that use markup/frontmatter syntaxes.
Closes #15
In general, users should be able to configure the plugin to run on these files since Biome can parse/format them on its own.