fix(dracut.sh): Ensure hardlink deduplication is reproducible - #2703
Closed
cjriches wants to merge 1 commit into
Closed
fix(dracut.sh): Ensure hardlink deduplication is reproducible#2703cjriches wants to merge 1 commit into
cjriches wants to merge 1 commit into
Conversation
By default, `hardlink` will only deduplicate files with identical mtimes, down to one-second granularity. If a dracut module rapidly generates multiple identical files, it is completely up to chance as to whether their mtimes cross a second boundary or not, and thus whether they get deduplicated or not. This results in non-reproducible output. Perform timestamp clamping before invoking `hardlink` if a reproducible build is requested.
Author
|
There's a few open questions / alternative approaches here:
|
Author
|
Linked RHEL bug ticket: https://issues.redhat.com/browse/RHEL-101901 |
aafeijoo-suse
approved these changes
Jul 9, 2025
aafeijoo-suse
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this hidden issue.
This repo is dead, could you please resubmit this to https://github.com/dracut-ng/dracut-ng?
Author
Thanks, have done: dracut-ng/dracut#1429 If you have the power to do so, I would suggest updating the README of this repo and marking it as archived, so that future contributors don't make the same mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default,
hardlinkwill only deduplicate files with identical mtimes, down to one-second granularity. If a dracut module rapidly generates multiple identical files, it is completely up to chance as to whether their mtimes cross a second boundary or not, and thus whether they get deduplicated or not. This results in non-reproducible output.Perform timestamp clamping before invoking
hardlinkif a reproducible build is requested.Checklist