Skip to content

Conversation

@frivoire
Copy link

@frivoire frivoire commented Aug 25, 2025

Why ?

After installing the operator with the latest version (1.2.1), we get an old CRD version, which lacks recent features (ex: the tiering block).
And I'm guessing that this old version is not intended, and just a forgotten step during the release process. Thus this PR to update it.

Notes

This PR seems huge in term of lines added/modified/removed, but I did no real change.
I only performed 2 steps:

cd ~/git/dragonfly-operator/

cp manifests/crd.yaml charts/dragonfly-operator/templates/crds.yaml
git add charts/dragonfly-operator/templates/crds.yaml
git ci -m "Copy simply CRD from manifests/ dir"

vim charts/dragonfly-operator/templates/crds.yaml
git add charts/dragonfly-operator/templates/crds.yaml
git ci -m "Reinclude the few helm wrapper lines (top & bottom of file)"

NB: also, don't hesitate to look at diff without whitespace (there has been changes in that area)

@frivoire frivoire changed the title Update CRD in chart fix(crd): update CRDs in chart Sep 3, 2025
@frivoire frivoire changed the title fix(crd): update CRDs in chart fix(helm): update CRDs in chart Sep 3, 2025
@Abhra303 Abhra303 self-requested a review September 10, 2025 07:09
@Abhra303
Copy link
Contributor

Thanks @frivoire, yep, looks like we forgot to update this crd. LGTM, can you fix the conflict?

@romange
Copy link
Contributor

romange commented Oct 1, 2025

@frivoire a friendly ping :)

@frivoire
Copy link
Author

frivoire commented Oct 1, 2025

I just recreated the git branch from scratch (using the same steps than given in the initial description) and force-pushed.
So it should include all recent changes, and without any conflict of course.

Copy link
Contributor

@Abhra303 Abhra303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abhra303
Copy link
Contributor

Abhra303 commented Oct 1, 2025

Can you please sign your commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants