-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add open addressing hash set #4705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BorysTheDev
wants to merge
5
commits into
main
Choose a base branch
from
feat_intrusive_string_set
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,814
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72aad85
to
54db498
Compare
54db498
to
9e074cf
Compare
f487504
to
6237fbd
Compare
085ba97
to
02002f1
Compare
a42f779
to
c0eef55
Compare
5af11e2
to
b2dcb0f
Compare
60557e7
to
14554d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising.
However, besides that code, the comprehensive documentation must also be added. For example, what to do if a new type should be added?
It seems additional testing should be added, i.e. memory leaks.
14554d9
to
9de47ea
Compare
9de47ea
to
4b874bc
Compare
4b874bc
to
d727095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4915
Added main functionality of OAHSet class
added tests
Current hash table is a classic open addressing hash table with linear probing, but with next modification:
For now, benchmarks are the next, but the code wasn't optimized for performance yet