feat(tiering): Serialized map #5896
Merged
+185
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
tiering-serialized-map
branch
from
18581a5 to
74bff56
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
BorysTheDev
reviewed
Oct 16, 2025
| namespace dfly::tiering { | ||
|
|
||
| SerializedMap::Iterator& SerializedMap::Iterator::operator++() { | ||
| slice_.remove_prefix(8 + key_.size() + value_.size()); |
There was a problem hiding this comment.
please add constexpr for 8
BorysTheDev
reviewed
Oct 16, 2025
| return; | ||
|
|
||
| uint32_t key_len = absl::little_endian::Load32(slice_.data()); | ||
| uint32_t value_len = absl::little_endian::Load32(slice_.data() + 4); |
BorysTheDev
previously approved these changes
Oct 16, 2025
Signed-off-by: Vladislav <[email protected]>
kostasrim
reviewed
Oct 16, 2025
|
|
||
| size_t SerializedMap::SerializeSize(Input input) { | ||
| size_t out = 4; // 4 byte number of entries | ||
| size_t out = kLenBytes; // number of entries |
There was a problem hiding this comment.
four * two or even better four times two sounds like math poetry 🤣
BorysTheDev
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You'll notice it has the same interface as #5889.
Doesn't have to be perfect or efficient, it's the first version of it. Just to exist and not be too much code at once