chore(hset_family): Add mutable functions to listpack wrapper #5901
+98
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
force-pushed
the
mutable-listpack
branch
2 times, most recently
from
28f6c20 to
486c619
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
mutable-listpack
branch
from
486c619 to
225e54e
Compare
BorysTheDev
reviewed
Oct 20, 2025
| mutable IntBuf intbuf_; | ||
| uint8_t* lp_; // the listpack itself | ||
| mutable IntBuf intbuf_; // buffer for integers decoded to strings | ||
| bool dirty_ = false; // whether lp_ was updated, but never retrieved with GetPointer |
There was a problem hiding this comment.
I don't see why do we need it
There was a problem hiding this comment.
Just to catch bugs because the interface is kinda bad 🙂
BorysTheDev
approved these changes
Oct 20, 2025
vyavdoshenko
pushed a commit
that referenced
this pull request
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mutable functions to listpack wrapper