feat(server): Add shutdown watchdog #5915
Merged
+41
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once server family completes its save on shutdown activity, a timer is started. If after 20 seconds the timer is not disarmed, stack traces for all fibers is printed to standard error, similar to what is done in test utils. Signed-off-by: Abhijat Malviya <[email protected]>
abhijat
force-pushed
the
abhijat/feat/shutdown-watchdog
branch
from
1ce7b87 to
5106b6b
Compare
abhijat
commented
Oct 15, 2025
romange
reviewed
Oct 15, 2025
src/server/main_service.cc
Outdated
| }; | ||
|
|
||
| ShutdownWatchdog::ShutdownWatchdog(util::ProactorPool& pp) : pool{pp} { | ||
| watchdog_fb = pool.GetNextProactor()->LaunchFiber([&] { |
There was a problem hiding this comment.
you can use LaunchFiber("name", cb) notation instead of calling util::ThisFiber::SetName
romange
reviewed
Oct 15, 2025
src/server/main_service.cc
Outdated
| absl::SetFlag(&FLAGS_alsologtostderr, true); | ||
| util::fb2::Mutex m; | ||
| pool.AwaitFiberOnAll([&m](unsigned index, auto*) { | ||
| util::ThisFiber::SetName("shutdown-watchdog"); |
There was a problem hiding this comment.
lets use a differrent name
There was a problem hiding this comment.
renamed to print_stack_fib_%u
romange
reviewed
Oct 15, 2025
Signed-off-by: Abhijat Malviya <[email protected]>
romange
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once server family completes its save on shutdown activity, a timer is started. If after 20 seconds the timer is not disarmed, stack traces for all fibers is printed to standard error, similar to what is done in test utils.
FIXES #5905
The watchdog is implemented as a static object which is armed on object creation, arming is only done once, future calls to arm are no-op. The time before logs are printed is fixed to 20 seconds.
Note on testing
I tested manually by adding
right after the
ArmShutdownWatchdog(service_.proactor_pool());call inServerFamily::Shutdown()and fiber stack traces were printed as expected on shutting down the server after 20 seconds.I considered adding some kind of environment variable or configuration for testing, to make the wait for
watchdog_doneto 0 and assert that stack trace is printed, but decided against it.Maybe there should be a setting for the sleep duration.