server: Yield fiber if running for over 1ms #5924
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using epoll as the event loop in debug mode, it has been observed that the stream consumption from redis in stable state can monopolize the core allowing no other fibers to run. To avoid this a yield is added similar to ListenerInterface::RunAcceptLoop() Signed-off-by: Abhijat Malviya <[email protected]>
abhijat
force-pushed
the
abhijat/fix/epoll-socket-yield-during-repl
branch
from
9fb586c to
77fdbb3
Compare
abhijat
commented
Oct 16, 2025
Comment on lines
+701
to
+704
| // Yield if the fiber has been running for long. | ||
| if (base::CycleClock::ToUsec(ThisFiber::GetRunningTimeCycles()) > 1000) { // 1ms | ||
| ThisFiber::Yield(); | ||
| } |
There was a problem hiding this comment.
Its not clear what tests to add for this, perhaps #4451 not failing (or continuing to fail) is a test
romange
approved these changes
Oct 16, 2025
kostasrim
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using epoll as the event loop in debug mode, it can be observed that the stream consumption fiber in stable state can monopolize the core allowing no other fibers to run. This causes CI failures when running on epoll + debug + single proactor thread.
To avoid this a yield is added similar to
ListenerInterface::RunAcceptLoop()FIXES #4451