fix: issue 1779: more correct way to add proxy_plugins values #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonflyoss/nydus#1779 Signed-off-by: Vladimir Larionov <[email protected]>
Signed-off-by: Vladimir Larionov <[email protected]>
botinca
changed the title
Member
gaius-qi
requested changes
Oct 17, 2025
Member
gaius-qi
left a comment
gaius-qi
left a comment
There was a problem hiding this comment.
Please update the dragonfly-stack verison.
imeoer
reviewed
Oct 20, 2025
| type = "snapshot" | ||
| address = "/run/containerd-nydus/containerd-nydus-grpc.sock" | ||
| EOF | ||
| #toml will create "proxy_plugins" table if it doesn't exist |
Contributor
There was a problem hiding this comment.
Maybe add a space after #. :)
Contributor
|
others LGTM, thanks! |
Member
|
@botinca Please fix lint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dragonflyoss/nydus#1779
Description
Implemented more correct way to manage proxy_plugins section
Modern version of toml-cli is able to work with toml section, so no need to use a dangerous construction cat <> EOF anymore
Related Issue
dragonflyoss/nydus#1779 bug
Motivation and Context
containerd stopped working after modification
/etc/containerd/config.tomlifproxy_pluginssection already exists