Add S3 backend support to Nydusify Commit #1775
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackowfish
force-pushed
the
jack/add-s3-to-commit
branch
from
b768d30 to
a70f3ec
Compare
Contributor
|
@jackowfish Great work, Please tidy up the commit message and sign it so that it can pass the DCO check. |
BraveY
reviewed
Oct 9, 2025
| if err := targetRemoter.Push(ctx, blobDesc, true, reader); err != nil { | ||
| return nil, errors.Wrap(err, "push blob with HTTP") | ||
| // Push to backend storage if configured, otherwise use registry | ||
| if blobBackend != nil { |
Contributor
There was a problem hiding this comment.
It seems the previous interface definition enforcing the use of paths wasn't very reasonable, which led to this workaround. It caused an extra disk write, resulting in additional overhead. Perhaps in the future, we could consider revising this backend's Upload interface to accept a reader instead.
Contributor
Others LGTM! |
imeoer
reviewed
Oct 13, 2025
imeoer
reviewed
Oct 13, 2025
| config.RootFS.DiffIDs = append(config.RootFS.DiffIDs, mountBlob.Desc.Digest) | ||
|
|
||
| // When using S3 backend, skip adding new blob DiffIDs since they won't be in manifest | ||
| if opt.BackendType != "s3" { |
Collaborator
There was a problem hiding this comment.
May be if opt.BackendType != "registry" {.
imeoer
reviewed
Oct 13, 2025
|
|
||
| // When using S3 backend, skip adding new blobs to manifest since they're referenced via URLs | ||
| // and Nydus only needs the bootstrap layer to function | ||
| if opt.BackendType != "s3" { |
imeoer
reviewed
Oct 13, 2025
| lowerDirs = strings.TrimPrefix(mount[0].Options[2], "lowerdir=") | ||
| upperDir = strings.TrimPrefix(mount[0].Options[1], "upperdir=") | ||
|
|
||
| // Parse overlay mount options properly - they can be in any order |
Signed-off-by: Jack Decker <[email protected]>
jackowfish
force-pushed
the
jack/add-s3-to-commit
branch
from
a70f3ec to
1df0a91
Compare
jackowfish
requested review from
BraveY,
imeoer and
liubogithub
and removed request for
a team
Signed-off-by: Jack Decker <[email protected]>
jackowfish
force-pushed
the
jack/add-s3-to-commit
branch
2 times, most recently
from
49c72b6 to
ba1a626
Compare
Signed-off-by: Jack Decker <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1775 +/- ##
==========================================
- Coverage 54.78% 54.74% -0.04%
==========================================
Files 199 199
Lines 54197 54274 +77
Branches 44727 44727
==========================================
+ Hits 29692 29714 +22
- Misses 23016 23071 +55
Partials 1489 1489
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding S3 backend support to nydusify commit
Related Issues
Change Details
Added S3 Backend support - similarly to how it's implemented for
nydusify convert- needed the ability to upload these commits directly to blob storage, so re-used most of the of the implementation from there.Test Results
Have tested via nerdctl to s3 and Cloudflare R2 - working as expected.
Change Type
Please select the type of change your pull request relates to:
Self-Checklist
Before submitting a pull request, please ensure you have completed the following: