- 
                Notifications
    
You must be signed in to change notification settings  - Fork 232
 
refactor(convert): restructure Nydus-to-OCI conversion workflow #1781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
          Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##           master    #1781      +/-   ##
==========================================
+ Coverage   54.87%   55.05%   +0.18%     
==========================================
  Files         199      199              
  Lines       54111    53709     -402     
  Branches    44727    44727              
==========================================
- Hits        29693    29571     -122     
+ Misses      22930    22660     -270     
+ Partials     1488     1478      -10     
 🚀 New features to boost your workflow:
  | 
    
181a9a6    to
    2c06c71      
    Compare
  
    | PushRetryDelay int | ||
| WithPlainHTTP bool | ||
| } | ||
| var execCommand = exec.Command //nolint:unused | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just delete the unused variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BraveY, thanks for the review. I kept this execCommand variable intentionally as it's reserved for unit tests later - I'll use it to mock exec.Command in test cases. Will remove it if it turns out unnecessary eventually.
2c06c71    to
    5e4e77e      
    Compare
  
    Signed-off-by: jxr <[email protected]>
5e4e77e    to
    2198f0a      
    Compare
  
    
Overview
This pull request refactors the Nydus-to-OCI reverse conversion workflow (originally implemented in PR #1741) by introducing explicit usage of acceleration-service and nydus-snapshotter APIs.
Related Issues
Related #1741, #1682
Change Details
Test Results
Change Type
Code Refactoring
Self-Checklist