Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-ui): inline format float box postion issue #4857

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 20, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review March 20, 2025 04:34
@Jocs Jocs requested review from jikkai and weird94 as code owners March 20, 2025 04:34
Copy link

github-actions bot commented Mar 20, 2025

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  25 passed

Details

stats  25 tests across 12 suites
duration  6 minutes, 5 seconds
commit  0a13627
info  For more information, see full report

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 34.12%. Comparing base (7601bab) to head (0a13627).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ckages/ui/src/views/components/popup/RectPopup.tsx 0.00% 18 Missing ⚠️
...s/docs-ui/src/controllers/float-menu.controller.ts 0.00% 12 Missing ⚠️
.../docs-ui/src/services/doc-popup-manager.service.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4857      +/-   ##
==========================================
- Coverage   34.13%   34.12%   -0.01%     
==========================================
  Files        2627     2627              
  Lines      136999   137014      +15     
  Branches    30414    30418       +4     
==========================================
  Hits        46760    46760              
- Misses      90239    90254      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jocs Jocs merged commit f1cbe91 into dev Mar 20, 2025
9 checks passed
@Jocs Jocs deleted the fix/float-box-postion branch March 20, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants