Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add event click #4862

Merged
merged 1 commit into from
Mar 20, 2025
Merged

fix: add event click #4862

merged 1 commit into from
Mar 20, 2025

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Mar 20, 2025

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Mar 20, 2025

Playwright test results

passed  25 passed

Details

stats  25 tests across 12 suites
duration  6 minutes, 8 seconds
commit  74e1f59
info  For more information, see full report

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 34.11%. Comparing base (f1cbe91) to head (74e1f59).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/scene.input-manager.ts 0.00% 19 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 12 Missing ⚠️
packages/engine-render/src/base-object.ts 0.00% 7 Missing ⚠️
packages/engine-render/src/engine.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4862   +/-   ##
=======================================
  Coverage   34.11%   34.11%           
=======================================
  Files        2627     2627           
  Lines      137014   137056   +42     
  Branches    30418    30427    +9     
=======================================
+ Hits        46742    46760   +18     
- Misses      90272    90296   +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lumixraku lumixraku merged commit 2e78781 into dev Mar 20, 2025
9 checks passed
@lumixraku lumixraku deleted the feat/event-click branch March 20, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants