Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-ui): disable float-menu on whole custom-range #4893

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Mar 29, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested review from jikkai and Jocs as code owners March 29, 2025 03:37
Copy link

github-actions bot commented Mar 29, 2025

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  25 passed

Details

stats  25 tests across 12 suites
duration  6 minutes, 6 seconds
commit  70a8756
info  For more information, see full report

@weird94 weird94 merged commit 57fa7d0 into dev Mar 29, 2025
9 checks passed
@weird94 weird94 deleted the fix/skip-whole-range-float-menu branch March 29, 2025 03:48
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.99%. Comparing base (f860829) to head (70a8756).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...s/docs-ui/src/controllers/float-menu.controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4893      +/-   ##
==========================================
- Coverage   34.01%   33.99%   -0.02%     
==========================================
  Files        2633     2633              
  Lines      137558   137561       +3     
  Branches    30554    30555       +1     
==========================================
- Hits        46785    46767      -18     
- Misses      90773    90794      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants