Conversation
dremin
approved these changes
Jan 8, 2025
Owner
dremin
left a comment
dremin
left a comment
There was a problem hiding this comment.
Nice! One thing I noticed is the option to set time is no longer bold. However, XP and Vista don't have this bold, while earlier versions do. Maybe it should be theme-controllable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some XAML refactoring and updating of method names to "fix naming rule", updating of control names and event handler methods. This is a working, merge-ready part of #461, otherwise it will never get merged!
RetroBar/PropertiesWindow.xamlto usex:Nameinstead ofNamefor consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]AutoStartCheckBoxcontrol tocbAutoStartfor consistency.RetroBar/PropertiesWindow.xaml.csto follow a consistent naming convention. [1] [2] [3]MenuItemresources and updated the context menu inRetroBar/Taskbar.xamlto use them as needed. [1] [2] [3]This seems even closer to the XP behavior. Once the template is abstracted/detached/unhardcoded from the taskbar, it should also allow the use of custom menu items for the theme (so the user can customize items to hide or show them, apart from the Exit option in Properties).