Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1107] Support readme responsive. #1115

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Dec 26, 2023

#1107

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [YSCODE-123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

Screenshot 2023-12-26 at 10 15 53 AM

@tannguyen04 tannguyen04 changed the title Feature/support readme responsive Support readme responsive. Dec 26, 2023
@tannguyen04 tannguyen04 changed the title Support readme responsive. [#1107] Support readme responsive. Dec 26, 2023
@@ -39,7 +39,7 @@ Use **tested** Drupal project template with DevOps integrations for CI and hosti

## Installation

curl -SsL https://install.drevops.com > install.php && php install.php; rm -r install.php
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will create a

 tag and it does not work well in td table.

@AlexSkrypnyk
Copy link
Member

@tannguyen04
The solution does not allow to copy the code with an on-screen copy code button.

is there any other way? Maybe putting a code block into a table with set width?

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (087c6e1) 70.54% compared to head (c2d4f51) 70.54%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1115   +/-   ##
========================================
  Coverage    70.54%   70.54%           
========================================
  Files           51       51           
  Lines         3181     3181           
========================================
  Hits          2244     2244           
  Misses         937      937           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tannguyen04
Copy link
Contributor Author

Hi @AlexSkrypnyk

I could not find other solution to make pre tag is scrollable inside td.
But if you allow using DIV tag instead of Table tag, our readme will be fully responsive.

@AlexSkrypnyk
Copy link
Member

@tannguyen04 please feel free to use any mechanisms available, as long as it renders correctly in the markup and the code has a copy button.

@AlexSkrypnyk
Copy link
Member

Implemented as inline code block to preserve the table. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants