-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1107] Support readme responsive. #1115
[#1107] Support readme responsive. #1115
Conversation
@@ -39,7 +39,7 @@ Use **tested** Drupal project template with DevOps integrations for CI and hosti | |||
|
|||
## Installation | |||
|
|||
curl -SsL https://install.drevops.com > install.php && php install.php; rm -r install.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will create a
tag and it does not work well in td table.
@tannguyen04 is there any other way? Maybe putting a code block into a table with set width? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1115 +/- ##
========================================
Coverage 70.54% 70.54%
========================================
Files 51 51
Lines 3181 3181
========================================
Hits 2244 2244
Misses 937 937 ☔ View full report in Codecov by Sentry. |
I could not find other solution to make pre tag is scrollable inside td. |
@tannguyen04 please feel free to use any mechanisms available, as long as it renders correctly in the markup and the code has a copy button. |
Implemented as inline code block to preserve the table. Closing this. |
#1107
Checklist before requesting a review
[YSCODE-123] Verb in past tense with dot at the end.
Changed
section about WHY something was done if this was not a normal implementationChanged
Screenshots