sdk: add calculateClientCollateralSize #25
Conversation
sdk/src/math/collateral.ts
Outdated
| ).value.amount | ||
| ); | ||
| return marketsAccount.markets.reduce((collateralVaultAmount, market) => { | ||
| return collateralVaultAmount.sub(market.amm.totalFee.div(new BN(2))); |
There was a problem hiding this comment.
Is this trying to calculate how much of the collateral is the users? If so i don't think you need to divide by two
There was a problem hiding this comment.
@0xbigz mentioned in Discord that the collateral wallet holds the user collateral plus the insurance fund, which is equal to the amount of half of the total fees collected (as in calculateInsuranceFundSize ). So this was my attempt to 'back out' the insurance portion from the collateral balance.
I may have misunderstood him though - @0xbigz thoughts?
There was a problem hiding this comment.
None of the fees are owned by the users, so I think it's safe to subtract the entire totalFee (the exchange can use them in various ways)
|
HI guys, I've pushed an update that removes the division. No conflicts it looks like, but a security check failed. |
2 participants
New helper method I am using in the discord bot, figured it might make sense to add directly to the SDK.