Wait for all close method to be completed before shutdown the ExecutorService#469
Open
intechsen wants to merge 5 commits intodromara:masterfrom
Open
Wait for all close method to be completed before shutdown the ExecutorService#469intechsen wants to merge 5 commits intodromara:masterfrom
intechsen wants to merge 5 commits intodromara:masterfrom
Conversation
…d. Such as after calling gracefulShutdown in the close method of TomcatWebServer
This reverts commit 91ec592.
…he thread. Such as after calling gracefulShutdown in the close method of TomcatWebServer" This reverts commit 2cb17fc.
…d. Such as after calling gracefulShutdown in the close method of TomcatWebServer. And reduce phase Close later
KamToHung
reviewed
Dec 15, 2024
| public void destroy() throws Exception { | ||
| if (this.running.compareAndSet(true, false)) { | ||
| shutdownInternal(); | ||
| DtpRegistry.getAllExecutors().forEach((k, v) -> DtpLifecycleSupport.destroy(v)); |
Collaborator
There was a problem hiding this comment.
可以设置awaitTerminationSeconds，延长等待时间
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TomcatWebServer等优雅下线异步逻辑，可能dynamictp线程池关闭后，但web容器还存在未释放的线程需要用到线程池，就会由于dynamictp已关闭而报错。
这里设置Phase-1，降低close调用的优先级，并且把完全shutdown线程池的时机，放到所有对象close后的销毁bean时再关闭线程池。