Add support for bucket object --folder option.#24
Open
markeissler wants to merge 4 commits intodrone-plugins:masterfrom
Open
Add support for bucket object --folder option.#24markeissler wants to merge 4 commits intodrone-plugins:masterfrom
markeissler wants to merge 4 commits intodrone-plugins:masterfrom
Conversation
Author
|
CI appears to be failing because of this error in Not sure how to deal with the |
Author
|
Bouncing this because there's no way to re-start the test. |
|
restarted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying a bucket object folder via a new
--folderoption. This update is meant to be backwards compatible with the current--targetoption and will append a path to any object path discovered from the initial--targetoption value.The motivation for this change is that I have a drone workflow wherein the
bucketvalue is retrieved from a drone secret (usingfrom_secret). I need to dynamically create the object name folder path during CI. By separating the bucket value from the folder path it makes this workflow possible.Both the README and tests have been updated in support of this PR.