Global upgrade of the plugin #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Why is the |
Contributor
Author
This file seems to be deleted in other maintained plugins, no? Without the file, golangci-lint works with the default configuration and linters (see more here). Let me know if you still want to keep it (but we will need to update it). Yes I can upgrade to Go 1.21 directly if you want |
Contributor
Author
|
Hello @donny-dont @tphoney, |
tphoney
approved these changes
Sep 28, 2023
|
thanks for the PR @utarwyn merged. |
Contributor
Author
|
Thank you for the quick review! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades some files and dependencies based on what are done in other Drone plugins.
Should be integrated before #155 in order to fix the build.