Ensure the order of database updates shown is consistent with how it would actually run #6376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I notice that this is in Draft. Please remove draft whenever this is ready for review. No rush. Thanks. |
codebymikey
force-pushed
the
consistent-db-update-order
branch
from
a0454e8 to
1a52962
Compare
codebymikey
requested review from
greg-1-anderson,
pfrenssen and
weitzman
as code owners
|
Added the tests, current upstream failures are related to the https://www.drupal.org/project/drupal/issues/3447617 issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the database update is listed in alphabetical order, rather than the actual order it would run.
This is especially the case when the
hook_update_dependencieshook is incorporated.Still need tests and some minor coding standards fixes, but pushing this up just so I don't lose/forget it.