Layout small improvements by pepeladeira · Pull Request #3898 · dubinc/dub

pepeladeira · 2026-05-13T01:03:12Z

Summary by CodeRabbit

Style
- Adjusted vertical spacing in commission analytics card headers for improved visual alignment.
Improvements
- Changed URL/update behavior so dashboard navigation now uses default scroll handling, preserving scroll position more consistently across sheets, tables, filters, and pagination for a smoother browsing experience.

vercel · 2026-05-13T01:03:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
dub	Ready	Preview	May 13, 2026 8:41pm

coderabbitai · 2026-05-13T01:03:27Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a5ff3d52-ef6c-404c-9bd8-d6e4bdca1ea1

📥 Commits

Reviewing files that changed from the base of the PR and between fa357d8 and eb70b47.

📒 Files selected for processing (59)

apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/network-partner-application-sheet.tsx
apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/page.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-table.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/leads/page.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/use-partner-customer-filters.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-composite-chart.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/analytics-partners-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-analytics-cards.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-funnel-chart.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-partners-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/use-applications-analytics-filters.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-analytics-cards.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-partners-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-status-selector.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/use-commissions-analytics-filters.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submission-details-sheet.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submission-row-menu.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submissions-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty/add-edit-bounty-sheet.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/commissions-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/fraud-group-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/resolved/resolved-fraud-group-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/use-fraud-group-filters.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/discounts/group-discounts.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/rewards/group-rewards.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/groups-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/network-partner-card.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/page-client.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/page-client.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/rejected/page-client.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-stats.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/billing/usage-chart.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/page-client.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/use-selected-guide.ts
apps/web/ui/analytics/device-section.tsx
apps/web/ui/analytics/location-section.tsx
apps/web/ui/analytics/partner-segments-section.tsx
apps/web/ui/analytics/referrers-utms.tsx
apps/web/ui/analytics/toggle.tsx
apps/web/ui/analytics/top-links.tsx
apps/web/ui/analytics/use-analytics-filters.tsx
apps/web/ui/customers/customers-table/customers-table.tsx
apps/web/ui/guides/guide-list.tsx
apps/web/ui/modals/start-paid-plan-modal.tsx
apps/web/ui/modals/trial-limit-activate-modal.tsx
apps/web/ui/partners/discounts/add-edit-discount-sheet.tsx
apps/web/ui/partners/fraud-risks/fraud-review-sheet.tsx
apps/web/ui/partners/partner-application-sheet.tsx
apps/web/ui/partners/partner-network/network-partner-sheet.tsx
apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
apps/web/ui/shared/simple-date-range-picker.tsx
apps/web/ui/submitted-leads/partner-profile-submitted-lead-sheet.tsx
apps/web/ui/submitted-leads/submitted-lead-sheet.tsx
apps/web/ui/submitted-leads/submitted-lead-table.tsx
packages/ui/src/hooks/use-pagination.ts

💤 Files with no reviewable changes (31)

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/discounts/group-discounts.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/rewards/group-rewards.tsx
apps/web/ui/modals/start-paid-plan-modal.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/billing/usage-chart.tsx
apps/web/ui/submitted-leads/submitted-lead-table.tsx
apps/web/ui/guides/guide-list.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-funnel-chart.tsx
apps/web/ui/shared/simple-date-range-picker.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/page-client.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/use-fraud-group-filters.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/page-client.tsx
apps/web/ui/modals/trial-limit-activate-modal.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submission-row-menu.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-stats.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/page-client.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/commissions-table.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-table.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/leads/page.tsx
apps/web/ui/customers/customers-table/customers-table.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/groups-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-composite-chart.tsx
apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/use-partner-customer-filters.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/fraud-group-table.tsx
apps/web/ui/analytics/toggle.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/rejected/page-client.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/resolved/resolved-fraud-group-table.tsx
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submissions-table.tsx

📝 Walkthrough

Walkthrough

This PR removes explicit { scroll: false } from many queryParams calls and changes the router helper default for scroll; a single padding tweak on a commission analytics card was also applied.

Changes

Query param scroll-option removal & router default

Layer / File(s)	Summary
Router helper default `packages/ui/src/hooks/use-router-stuff.ts`	The `queryParams` callback in `useRouterStuff` now defaults `scroll` to `false` instead of `true`.
Analytics filter hooks & UI `apps/web/.../use-analytics-filters.tsx`, `use-commissions-analytics-filters.tsx`, `use-applications-analytics-filters.tsx`, `apps/web/ui/analytics/*`	Multiple filter selection/removal/toggle handlers and analytics UI components stopped passing `{ scroll: false }` to `queryParams`.
Tables, row clicks, sorts, and sheets `apps/web/.../tables/.tsx`, `Sheet.tsx`, `page-client.tsx`	Table row click handlers, sort change handlers, and Sheet onClose/previous/next navigation calls no longer pass `scroll: false`.
Pagination & small UI helpers `packages/ui/src/hooks/use-pagination.ts`, guides, modals, date pickers	Pagination URL sync and various small UI helpers drop the `scroll: false` option.
Commission analytics card padding `apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-analytics-cards.tsx`	Fallback header padding changed from `py-3` to `py-4`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

dubinc/dub#3699: Both PRs modify packages/ui/src/hooks/use-router-stuff.ts around queryParams/scroll handling for preserving/restoring dashboard scrollTop.
dubinc/dub#3803: Touches commissions analytics UI and query-param flows related to this PR.
dubinc/dub#3659: Related edits to analytics partner filter URL updates and scroll handling.

Suggested reviewers

steven-tey

Poem

🐰 A small hop, a minor scroll delight,
Query params tidy up, headers sit just right,
Navigation hums with defaults now aligned,
Tiny tweaks, dashboard calm — the code refined.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title 'Layout small improvements' is vague and does not accurately reflect the actual changes, which primarily involve removing scroll behavior overrides from navigation/query parameter updates across many files.	Use a more specific title that captures the main change, such as 'Remove scroll: false option from queryParams calls' or 'Refactor scroll handling in router navigation'.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch layout-small-improvements

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/page.tsx

Parsing error: The keyword 'import' is reserved

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/use-commissions-analytics-filters.tsx

Parsing error: The keyword 'import' is reserved

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-analytics-cards.tsx

Parsing error: The keyword 'import' is reserved

25 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

use-router scroll and commission height

fa357d8

vercel Bot deployed to Preview May 13, 2026 01:13 View deployment

Merge branch 'main' into layout-small-improvements

f325cdf

vercel Bot deployed to Preview May 13, 2026 20:03 View deployment

remove all scrol: false

eb70b47

vercel Bot deployed to Preview May 13, 2026 20:41 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Layout small improvements#3898

Layout small improvements#3898
pepeladeira wants to merge 3 commits into
mainfrom
layout-small-improvements

pepeladeira commented May 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented May 13, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 13, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (2 warnings)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

pepeladeira commented May 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (2 warnings)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

pepeladeira commented May 13, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented May 13, 2026 •

edited

Loading

coderabbitai Bot commented May 13, 2026 •

edited

Loading