Add interrupt handle #493
Open
Add interrupt handle #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes the `duckdb_interrupt` function from the C API to allow consumers to interrupt long-running queries from another thread. Inspired by rusqlite: https://docs.rs/rusqlite/latest/rusqlite/struct.InterruptHandle.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
InterruptHandlethat allows interrupting long-running queries from another thread. Internally, this calls theduckdb_interruptfunction from the C API. The implementation is inspired by rusqlite.It seems to get the job done, but a couple of thoughts:
ErrorCode::Unknown, so we have to resort to a match on the error message. Works for now, but I'm wondering if there is a way to do this in a cleaner way, or if the actual error code is simply not exposed from the underlying API.Previous attempt at adding this feature: #343.