Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route VPN controller outside VPN #5811

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Route VPN controller outside VPN #5811

wants to merge 2 commits into from

Conversation

aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Mar 21, 2025 •
edited by karlenDimla
Loading

Task/Issue URL: https://app.asana.com/0/1198194956794324/1209751280857952/f

Description

Fix routing the VPN controller traffic outside the tunnel

Steps to test this PR

You should really test this in #5811 instead

Test failure recovery

  • build assembleID and install app
  • Enable VPN
  • go to settings -> NetP dev settings and tap in Simulate egress failure
  • filter logcat by Failure recovery
  • verify tunnel recovers after some minutes (~10min) -- you can lower to ~1min changing MAX_ATTEMPTS_WITH_NO_HS_EPOC value to 1

@aitorvs Graphite App
Copy link
Collaborator Author

aitorvs commented Mar 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aitorvs aitorvs mentioned this pull request Mar 21, 2025
Open
5 tasks
@aitorvs aitorvs force-pushed the fix/aitor/vpn/controller-outside-vpn branch from 3fea454 to d8cce85 Compare March 25, 2025 18:17
@aitorvs aitorvs force-pushed the fix/aitor/vpn/controller-outside-vpn branch 2 times, most recently from 104c590 to 87f9d85 Compare April 6, 2025 09:30
@aitorvs aitorvs marked this pull request as ready for review April 6, 2025 14:50
@aitorvs aitorvs force-pushed the fix/aitor/vpn/controller-outside-vpn branch 2 times, most recently from a3aac64 to d8c864d Compare April 7, 2025 13:00
karlenDimla
karlenDimla approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@karlenDimla karlenDimla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the device I had 3 times (no modifications) and all managed to recover on their own.

@aitorvs aitorvs force-pushed the fix/aitor/vpn/controller-outside-vpn branch from d8c864d to a4a6d72 Compare April 8, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlenDimla karlenDimla karlenDimla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aitorvs @karlenDimla