Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate worker for scam, so it can handle RC updates immediately #5857

Open
wants to merge 2 commits into
base: feature/cris/scam-protection/add-support-for-scam-protection
Choose a base branch
from

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Apr 4, 2025

Task/Issue URL: https://app.asana.com/0/0/1209893469792815/f

Description

Steps to test this PR

Feature 1

Feature 2

  • Without reinstalling the app, enable scamProtection under Feature Flag Inventory and restart the app
  • Using the app inspector, check that phishing, malware and scam datasets are present. Data needs to be downloaded, so it might take a few seconds to complete. The easiest way is to check the revisions table in malicious_sites db
  • Open https://privacy-test-pages.site/security/badware/scam.html and check it's blocked.
  • Disable scamProtection under Feature Flag Inventory and restart the app
  • Open https://privacy-test-pages.site/security/badware/scam.html and check it's not blocked

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

Copy link
Contributor Author

CrisBarreiro commented Apr 4, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/scam-protection/add-support-for-scam-protection branch from d18103b to 68dccd5 Compare April 4, 2025 10:14
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/scam-protection/add-separate-worker-for-scam branch 3 times, most recently from 01ccafb to f8bc86b Compare April 4, 2025 11:04
@CrisBarreiro CrisBarreiro requested a review from cmonfortep April 4, 2025 11:08
@CrisBarreiro CrisBarreiro marked this pull request as ready for review April 4, 2025 11:08
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/scam-protection/add-support-for-scam-protection branch from 68dccd5 to 4e93bfa Compare April 7, 2025 09:04
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/scam-protection/add-separate-worker-for-scam branch from f8bc86b to 9ed1aca Compare April 7, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant