Skip to content

Upgrade to v2.3.2 of Admin-lte #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

gcheema
Copy link

@gcheema gcheema commented Dec 1, 2015

I have upgraded your gem latest version of admin-lte. Along the way I ended up removing dependent libs because they can be included separately via gems, if one needs to include it.

I am using latest version of gem myself and all looking good so far.

@@ -1,5 +1,5 @@
module AdminLTE
module Rails
VERSION = '1.3.3'
VERSION = '2.3.2'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

get "#{css_path}/skins/skin-blue.css", 'stylesheets/skin-blue.css'

# Get Plugins stylesheets
plugins_path = "#{remote}/raw/#{tag}/plugins"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants