Handle original query for URLs without ? character#40
Open
chris-jamieson wants to merge 1 commit intodvonlehman:masterfrom
Open
Handle original query for URLs without ? character#40chris-jamieson wants to merge 1 commit intodvonlehman:masterfrom
chris-jamieson wants to merge 1 commit intodvonlehman:masterfrom
Conversation
When using `originalQuery: true` option, if the URL does not have a `?` character, the regex `/^.+\?/` causes the entire request URL to be set as the `search` parameter. This change checks for the presence of a `?` character in the string, and sets an empty string as the search parameter if not present.
Pull Request Test Coverage Report for Build 90
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
originalQuery: trueoption, if the URL does not have a?character, the regex/^.+\?/causes the entire request URL to be set as thesearchparameter. This change checks for the presence of a?character in the string, and sets an empty string as the search parameter if not present.At present, the query logic does not account for URLs without a
?character.For example, a request with URL
http://example.com/foowith optionoriginalQuery: truewould be transformed tohttps://my-proxy-destination.com/bar?http://example.com/foo, whilehttp://example.com/foo?id=4would correctly be transformed to `https://my-proxy-destination.com/bar?id=4The correct behaviour for URLs without a query string (and therefore no
?character) is that no query should be set to the proxy URL.