Skip to content

replace pandas datareader with yfinance #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2023
Merged

replace pandas datareader with yfinance #22

merged 3 commits into from
Feb 14, 2023

Conversation

pierrelouisp
Copy link
Contributor

randomir
randomir reviewed Feb 9, 2023
View reviewed changes
single_period.py Outdated
@@ -297,7 +298,7 @@ def solve_cqm(self, max_risk=None, min_return=None, init_holdings=None):
label="Example - Portfolio Optimization")
n_samples = len(self.sample_set['CQM'].record)

feasible_samples = self.sample_set['CQM'].filter(lambda d: d.is_feasible)
feasible_samples = (self.sample_set['CQM']).filter(lambda d: d.is_feasible)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parentheses not needed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the remnants of some debugging that got left in inadvertently. Fixed. Thanks!

@vgoliber vgoliber merged commit c80da1a into dwave-examples:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomir randomir randomir left review comments

@vgoliber vgoliber vgoliber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to query data from Yahoo! finance using pandas DataReader
3 participants
@pierrelouisp @randomir @vgoliber