Added separate class + function for (only) wasm module validation#1250
Conversation
|
Hey @jeff-schram ! Happy to see you around! I'm on the phone now, but looks a perfectly legit improvement, will review tomorrow 👍 |
|
Hey @andreaTP, there's no rush, so take your time. BTW This morning I also set out to reproduce the issue I had with and Exception being thrown when running a module with exception proposal opcodes, but apparently that already got fixed with 0.7.3, so the next time we meet the first round at the free after party is on me ;) |
|
Quick check, most of the fixes in 1.7.3 are in the interpreter. Use at least the runtime compiler for maximum performance, but maybe you are emitting very, very small WASM files (which would be a great thing, though) where execution is not dominating. I'm in for the after-party! |
|
Most likely the interpreter. I have no configuration for Chicory at all and every instance is only used once. The use case is unit tests, so (very) small modules with less than ten (exported) functions and each of them is only called once. |
There was a problem hiding this comment.
LGTM, thanks a lot for the improvement @jeff-schram !
|
@jeff-schram those changes are available in the |
|
@andreaTP Just wired it into my project :). To quote the great Eric Theodore Cartman: "sweeeeet". I will create a (draft) PR for the binaryen addition after Easter. |
2 participants
My use case requires only validation of a wasm module, hence the proposal for creating a class + function that does just that.