Fix AOT plugin injecting class files into sources JAR (#1254)#1255
Draft
andreaTP wants to merge 1 commit intodylibso:mainfrom
Draft
Fix AOT plugin injecting class files into sources JAR (#1254)#1255andreaTP wants to merge 1 commit intodylibso:mainfrom
andreaTP wants to merge 1 commit intodylibso:mainfrom
Conversation
Write generated .class files directly to the build output directory instead of a resources folder, and register only the wasm metadata folder as a Maven resource. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Assuming your checks verify that the built results are still available for further compilations, it looks decent to me. Would you like me to give it a try with prism to confirm it looks good? |
Collaborator
Author
|
Yes, please, another careful couple of eyes on the results of those changes is very much appreciated @headius 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1254 wdyt @headius ?
Write generated .class files directly to the build output directory instead of a resources folder, and register only the wasm metadata folder as a Maven resource.
Honestly it looked better before ... but, well, if it solves an issue ...