Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lockup): get lock creation fee from params #1762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented Feb 27, 2025

Description


Closes #1760

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@zale144 zale144 self-assigned this Feb 27, 2025
@zale144 zale144 requested a review from a team as a code owner February 27, 2025 23:11
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 16.12903% with 52 lines in your changes missing coverage. Please review.

Project coverage is 22.65%. Comparing base (0fdd5de) to head (a5289e4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
x/lockup/types/params.pb.go 0.00% 43 Missing ⚠️
x/lockup/types/params.go 43.75% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1762      +/-   ##
==========================================
+ Coverage   22.54%   22.65%   +0.10%     
==========================================
  Files         591      591              
  Lines      129993   130042      +49     
==========================================
+ Hits        29309    29455     +146     
+ Misses      96797    96686     -111     
- Partials     3887     3901      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change lock creation fee to be a param
1 participant