Added new filter effect shakeoscillate#201
Conversation
jaromil
force-pushed
the
origin/shakeoscillate
branch
2 times, most recently
from
ff2e225 to
facfe48
Compare
|
|
||
| } | ||
|
|
||
| void clearScreen(cairo_t* cr, int width, int height) { |
There was a problem hiding this comment.
Parameters width and height are unused in this function and can be removed.
|
|
||
| private: | ||
|
|
||
| unsigned int width; |
There was a problem hiding this comment.
It is not necessary to declare width and height here, see frei0r.hpp.
| register_param(this->phase, "phase", "The phase of the sin and cos functions of this effect."); | ||
| register_param(this->mirrored, "mirrored", "On/Off Image Mirror Extend"); | ||
|
|
||
| this->width = width; |
There was a problem hiding this comment.
width and height are already set in the parent constructor, no need to do this here.
jaromil
force-pushed
the
origin/shakeoscillate
branch
from
facfe48 to
a0ded73
Compare
jaromil
force-pushed
the
origin/shakeoscillate
branch
from
a0ded73 to
55d42f7
Compare
jaromil
force-pushed
the
origin/shakeoscillate
branch
from
55d42f7 to
a718fa6
Compare
|
Thanks for working on this, |
|
Will this be made available soon? |
jaromil
force-pushed
the
origin/shakeoscillate
branch
from
a718fa6 to
00f5503
Compare
❌ Conventional Commits check failedOne or more commit messages in this PR do not follow the Invalid commits:
Expected format Examples
Please fix the commit messages (e.g. via |
|
Any update about when this will be available? |
|
I have reworked this in a clean branch with a squashed commit history to comply with Conventional Commits and improve reviewability. The updated implementation is available here: |
5 participants
rebase of PR #197 by @JohannJEG