Skip to content

SSR Performance Name Change #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexanderKaran merged 1 commit into from
Jun 22, 2026
Merged

SSR Performance Name Change #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions .github/frameworks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"package": "app-baseline-html",
"buildScript": "build",
"buildOutputDir": ".",
"measurements": [{ "type": "ssr" }]
"measurements": [{ "type": "ssrRequestThroughput" }]
}
},
{
Expand All @@ -31,9 +31,9 @@
"buildScript": "build",
"buildOutputDir": "dist",
"measurements": [
{ "type": "ssr" },
{ "type": "ssrRequestThroughput" },
{ "type": "clientSideRendered" },
{ "type": "mpa" }
{ "type": "serverSideRendered" }
]
}
},
Expand All @@ -56,7 +56,7 @@
"package": "app-mastro",
"buildScript": "build",
"buildOutputDir": "generated",
"measurements": [{ "type": "ssr" }]
"measurements": [{ "type": "ssrRequestThroughput" }]
}
},
{
Expand All @@ -79,9 +79,9 @@
"buildScript": "build",
"buildOutputDir": ".next",
"measurements": [
{ "type": "ssr" },
{ "type": "ssrRequestThroughput" },
{ "type": "clientSideRendered" },
{ "type": "mpa" }
{ "type": "serverSideRendered" }
]
}
},
Expand All @@ -105,9 +105,9 @@
"buildScript": "build",
"buildOutputDir": ".output",
"measurements": [
{ "type": "ssr" },
{ "type": "ssrRequestThroughput" },
{ "type": "clientSideRendered" },
{ "type": "mpa" }
{ "type": "serverSideRendered" }
]
}
},
Expand All @@ -131,9 +131,9 @@
"buildScript": "build",
"buildOutputDir": "build",
"measurements": [
{ "type": "ssr" },
{ "type": "ssrRequestThroughput" },
{ "type": "clientSideRendered" },
{ "type": "mpa" }
{ "type": "serverSideRendered" }
]
}
},
Expand All @@ -157,9 +157,9 @@
"buildScript": "build",
"buildOutputDir": ".output",
"measurements": [
{ "type": "ssr" },
{ "type": "ssrRequestThroughput" },
{ "type": "clientSideRendered" },
{ "type": "mpa" }
{ "type": "serverSideRendered" }
]
}
},
Expand All @@ -183,9 +183,9 @@
"buildScript": "build",
"buildOutputDir": "build",
"measurements": [
{ "type": "ssr" },
{ "type": "ssrRequestThroughput" },
{ "type": "clientSideRendered" },
{ "type": "mpa" }
{ "type": "serverSideRendered" }
]
}
},
Expand All @@ -209,9 +209,9 @@
"buildScript": "build",
"buildOutputDir": ".output",
"measurements": [
{ "type": "ssr" },
{ "type": "ssrRequestThroughput" },
{ "type": "clientSideRendered" },
{ "type": "mpa" }
{ "type": "serverSideRendered" }
]
}
}
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/generate-stats.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
outputs:
install-matrix: ${{ steps.set-matrix.outputs.install }}
build-matrix: ${{ steps.set-matrix.outputs.build }}
ssr-matrix: ${{ steps.set-matrix.outputs.ssr }}
ssr-request-throughput-matrix: ${{ steps.set-matrix.outputs.ssr-request-throughput }}
deps-matrix: ${{ steps.set-matrix.outputs.deps }}
spa-matrix: ${{ steps.set-matrix.outputs.spa }}
mpa-matrix: ${{ steps.set-matrix.outputs.mpa }}
client-side-rendered-matrix: ${{ steps.set-matrix.outputs.client-side-rendered }}
server-side-rendered-matrix: ${{ steps.set-matrix.outputs.server-side-rendered }}
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand All @@ -38,21 +38,21 @@ jobs:
FRAMEWORKS=$(cat .github/frameworks.json)
echo "install=$(echo "$FRAMEWORKS" | jq -c '[.[] | select(.starter) | select(.starter.measurements | map(.type) | contains(["install"])) | {name, displayName, package: .starter.package, buildScript: .starter.buildScript, buildOutputDir: .starter.buildOutputDir, measurements: .starter.measurements}]')" >> $GITHUB_OUTPUT
echo "build=$(echo "$FRAMEWORKS" | jq -c '[.[] | select(.starter) | select(.starter.measurements | map(.type) | contains(["build"])) | {name, displayName, package: .starter.package, buildScript: .starter.buildScript, buildOutputDir: .starter.buildOutputDir, measurements: .starter.measurements}]')" >> $GITHUB_OUTPUT
echo "ssr=$(echo "$FRAMEWORKS" | jq -c '[.[] | select(.app) | select(.app.measurements | map(.type) | contains(["ssr"])) | {name, displayName, package: .app.package, buildScript: .app.buildScript, buildOutputDir: .app.buildOutputDir, measurements: .app.measurements}]')" >> $GITHUB_OUTPUT
echo "ssr-request-throughput=$(echo "$FRAMEWORKS" | jq -c '[.[] | select(.app) | select(.app.measurements | map(.type) | contains(["ssrRequestThroughput"])) | {name, displayName, package: .app.package, buildScript: .app.buildScript, buildOutputDir: .app.buildOutputDir, measurements: .app.measurements}]')" >> $GITHUB_OUTPUT
echo "deps=$(echo "$FRAMEWORKS" | jq -c '[.[] | select(.starter) | select(.starter.measurements | map(.type) | contains(["dependencies"])) | {name, displayName, package: .starter.package}]')" >> $GITHUB_OUTPUT
echo "spa=$(echo "$FRAMEWORKS" | jq -c '[.[] | select(.app) | select(.app.measurements | map(.type) | contains(["clientSideRendered"])) | {name, displayName, package: .app.package, buildScript: .app.buildScript, buildOutputDir: .app.buildOutputDir, measurements: .app.measurements}]')" >> $GITHUB_OUTPUT
echo "mpa=$(echo "$FRAMEWORKS" | jq -c '[.[] | select(.app) | select(.app.measurements | map(.type) | contains(["mpa"])) | {name, displayName, package: .app.package, buildScript: .app.buildScript, buildOutputDir: .app.buildOutputDir, measurements: .app.measurements}]')" >> $GITHUB_OUTPUT
echo "client-side-rendered=$(echo "$FRAMEWORKS" | jq -c '[.[] | select(.app) | select(.app.measurements | map(.type) | contains(["clientSideRendered"])) | {name, displayName, package: .app.package, buildScript: .app.buildScript, buildOutputDir: .app.buildOutputDir, measurements: .app.measurements}]')" >> $GITHUB_OUTPUT
echo "server-side-rendered=$(echo "$FRAMEWORKS" | jq -c '[.[] | select(.app) | select(.app.measurements | map(.type) | contains(["serverSideRendered"])) | {name, displayName, package: .app.package, buildScript: .app.buildScript, buildOutputDir: .app.buildOutputDir, measurements: .app.measurements}]')" >> $GITHUB_OUTPUT

measure:
needs: setup
uses: ./.github/workflows/measure-framework.yml
with:
install-matrix: ${{ needs.setup.outputs.install-matrix }}
build-matrix: ${{ needs.setup.outputs.build-matrix }}
ssr-matrix: ${{ needs.setup.outputs.ssr-matrix }}
ssr-request-throughput-matrix: ${{ needs.setup.outputs.ssr-request-throughput-matrix }}
deps-matrix: ${{ needs.setup.outputs.deps-matrix }}
spa-matrix: ${{ needs.setup.outputs.spa-matrix }}
mpa-matrix: ${{ needs.setup.outputs.mpa-matrix }}
client-side-rendered-matrix: ${{ needs.setup.outputs.client-side-rendered-matrix }}
server-side-rendered-matrix: ${{ needs.setup.outputs.server-side-rendered-matrix }}

generate-stats:
needs: [setup, measure]
Expand Down
54 changes: 27 additions & 27 deletions .github/workflows/measure-framework.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,22 @@ on:
description: 'JSON array of frameworks to measure build time'
type: string
required: true
ssr-matrix:
description: 'JSON array of frameworks to measure SSR performance'
ssr-request-throughput-matrix:
description: 'JSON array of frameworks to measure SSR request throughput performance'
type: string
required: true
deps-matrix:
description: 'JSON array of frameworks to run e18e dependency analysis'
type: string
required: false
default: '[]'
spa-matrix:
description: 'JSON array of frameworks to measure SPA paint and interaction performance'
client-side-rendered-matrix:
description: 'JSON array of frameworks to measure client-side rendered paint and interaction performance'
type: string
required: false
default: '[]'
mpa-matrix:
description: 'JSON array of frameworks to measure MPA paint and interaction performance'
server-side-rendered-matrix:
description: 'JSON array of frameworks to measure server-side rendered paint and interaction performance'
type: string
required: false
default: '[]'
Expand Down Expand Up @@ -118,13 +118,13 @@ jobs:
retention-days: 1
if-no-files-found: warn

measure-ssr:
if: inputs.ssr-matrix != '[]'
measure-ssr-request-throughput:
if: inputs.ssr-request-throughput-matrix != '[]'
runs-on: depot-ubuntu-24.04
strategy:
fail-fast: false
matrix:
framework: ${{ fromJson(inputs.ssr-matrix) }}
framework: ${{ fromJson(inputs.ssr-request-throughput-matrix) }}
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand All @@ -149,15 +149,15 @@ jobs:
working-directory: ./packages/${{ matrix.framework.package }}
run: pnpm build

- name: Run SSR benchmark
run: pnpm --filter @framework-tracker/stats-generator run:ssr ${{ matrix.framework.package }}
- name: Run SSR request throughput benchmark
run: pnpm --filter @framework-tracker/stats-generator run:ssr-request-throughput ${{ matrix.framework.package }}
env:
RUNNER_LABEL: ubuntu-latest

- name: Upload SSR stats
- name: Upload SSR request throughput stats
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: ssr-stats-${{ matrix.framework.name }}
name: ssr-request-throughput-stats-${{ matrix.framework.name }}
path: packages/${{ matrix.framework.package }}/ci-stats.json
retention-days: 1
if-no-files-found: error
Expand Down Expand Up @@ -198,16 +198,16 @@ jobs:
retention-days: 1
if-no-files-found: error

measure-spa:
if: inputs.spa-matrix != '[]'
measure-client-side-rendered:
if: inputs.client-side-rendered-matrix != '[]'
runs-on: depot-ubuntu-24.04
container:
image: mcr.microsoft.com/playwright:v1.49.0-noble
options: --ipc=host
strategy:
fail-fast: false
matrix:
framework: ${{ fromJson(inputs.spa-matrix) }}
framework: ${{ fromJson(inputs.client-side-rendered-matrix) }}
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand All @@ -234,31 +234,31 @@ jobs:
env:
BUILD_MODE: spa

- name: Run SPA benchmark
run: pnpm --filter @framework-tracker/stats-generator run:spa ${{ matrix.framework.package }}
- name: Run client-side rendered benchmark
run: pnpm --filter @framework-tracker/stats-generator run:client-side-rendered ${{ matrix.framework.package }}
env:
PLAYWRIGHT_BROWSERS_PATH: /ms-playwright
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
RUNNER_LABEL: ubuntu-latest

- name: Upload SPA stats
- name: Upload client-side rendered stats
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: spa-stats-${{ matrix.framework.name }}
name: client-side-rendered-stats-${{ matrix.framework.name }}
path: packages/${{ matrix.framework.package }}/ci-stats.json
retention-days: 1
if-no-files-found: error

measure-mpa:
if: inputs.mpa-matrix != '[]'
measure-server-side-rendered:
if: inputs.server-side-rendered-matrix != '[]'
runs-on: depot-ubuntu-24.04
container:
image: mcr.microsoft.com/playwright:v1.49.0-noble
options: --ipc=host
strategy:
fail-fast: false
matrix:
framework: ${{ fromJson(inputs.mpa-matrix) }}
framework: ${{ fromJson(inputs.server-side-rendered-matrix) }}
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand All @@ -283,17 +283,17 @@ jobs:
working-directory: ./packages/${{ matrix.framework.package }}
run: pnpm build

- name: Run MPA benchmark
run: pnpm --filter @framework-tracker/stats-generator run:mpa ${{ matrix.framework.package }}
- name: Run server-side rendered benchmark
run: pnpm --filter @framework-tracker/stats-generator run:server-side-rendered ${{ matrix.framework.package }}
env:
PLAYWRIGHT_BROWSERS_PATH: /ms-playwright
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
RUNNER_LABEL: ubuntu-latest

- name: Upload MPA stats
- name: Upload server-side rendered stats
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: mpa-stats-${{ matrix.framework.name }}
name: server-side-rendered-stats-${{ matrix.framework.name }}
path: packages/${{ matrix.framework.package }}/ci-stats.json
retention-days: 1
if-no-files-found: error
8 changes: 4 additions & 4 deletions .github/workflows/preview-stats.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
outputs:
install-matrix: ${{ steps.detect.outputs.install }}
build-matrix: ${{ steps.detect.outputs.build }}
ssr-matrix: ${{ steps.detect.outputs.ssr }}
ssr-request-throughput-matrix: ${{ steps.detect.outputs.ssr-request-throughput }}
deps-matrix: ${{ steps.detect.outputs.deps }}
framework-names: ${{ steps.detect.outputs.framework-names }}
has-changes: ${{ steps.detect.outputs.has-changes }}
Expand Down Expand Up @@ -45,7 +45,7 @@ jobs:
echo "framework-names=[]" >> $GITHUB_OUTPUT
echo "install=[]" >> $GITHUB_OUTPUT
echo "build=[]" >> $GITHUB_OUTPUT
echo "ssr=[]" >> $GITHUB_OUTPUT
echo "ssr-request-throughput=[]" >> $GITHUB_OUTPUT
exit 0
fi

Expand All @@ -67,7 +67,7 @@ jobs:

echo "install=$(echo "$FRAMEWORKS" | jq -c --argjson names "$NAMES_JSON" '[.[] | select(.name as $n | $names | contains([$n])) | select(.starter) | select(.starter.measurements | map(.type) | contains(["install"])) | {name, displayName, package: .starter.package, buildScript: .starter.buildScript, buildOutputDir: .starter.buildOutputDir, measurements: .starter.measurements}]')" >> $GITHUB_OUTPUT
echo "build=$(echo "$FRAMEWORKS" | jq -c --argjson names "$NAMES_JSON" '[.[] | select(.name as $n | $names | contains([$n])) | select(.starter) | select(.starter.measurements | map(.type) | contains(["build"])) | {name, displayName, package: .starter.package, buildScript: .starter.buildScript, buildOutputDir: .starter.buildOutputDir, measurements: .starter.measurements}]')" >> $GITHUB_OUTPUT
echo "ssr=$(echo "$FRAMEWORKS" | jq -c --argjson names "$NAMES_JSON" '[.[] | select(.name as $n | $names | contains([$n])) | select(.app) | select(.app.measurements | map(.type) | contains(["ssr"])) | {name, displayName, package: .app.package, buildScript: .app.buildScript, buildOutputDir: .app.buildOutputDir, measurements: .app.measurements}]')" >> $GITHUB_OUTPUT
echo "ssr-request-throughput=$(echo "$FRAMEWORKS" | jq -c --argjson names "$NAMES_JSON" '[.[] | select(.name as $n | $names | contains([$n])) | select(.app) | select(.app.measurements | map(.type) | contains(["ssrRequestThroughput"])) | {name, displayName, package: .app.package, buildScript: .app.buildScript, buildOutputDir: .app.buildOutputDir, measurements: .app.measurements}]')" >> $GITHUB_OUTPUT
echo "deps=$(echo "$FRAMEWORKS" | jq -c --argjson names "$NAMES_JSON" '[.[] | select(.name as $n | $names | contains([$n])) | select(.starter) | select(.starter.measurements | map(.type) | contains(["dependencies"])) | {name, displayName, package: .starter.package}]')" >> $GITHUB_OUTPUT

measure:
Expand All @@ -77,7 +77,7 @@ jobs:
with:
install-matrix: ${{ needs.setup.outputs.install-matrix }}
build-matrix: ${{ needs.setup.outputs.build-matrix }}
ssr-matrix: ${{ needs.setup.outputs.ssr-matrix }}
ssr-request-throughput-matrix: ${{ needs.setup.outputs.ssr-request-throughput-matrix }}
deps-matrix: ${{ needs.setup.outputs.deps-matrix }}

preview-comment:
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/validate-stats.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ jobs:
run: |
set -e

echo "=== Running SSR benchmarks ==="
echo "=== Running SSR request throughput benchmarks ==="
FRAMEWORKS=$(cat .github/frameworks.json)
echo "$FRAMEWORKS" | jq -c '.[] | select(.app)' | while read -r framework; do
PKG=$(echo "$framework" | jq -r '.app.package')
echo "Building $PKG..."
(cd packages/$PKG && pnpm build)
echo "Running SSR benchmark for $PKG..."
pnpm --filter @framework-tracker/stats-generator run:ssr $PKG
echo "Running SSR request throughput benchmark for $PKG..."
pnpm --filter @framework-tracker/stats-generator run:ssr-request-throughput $PKG
done

echo ""
Expand All @@ -73,25 +73,25 @@ jobs:
done

echo ""
echo "=== Running SPA benchmarks ==="
echo "=== Running client-side rendered benchmarks ==="
FRAMEWORKS=$(cat .github/frameworks.json)
echo "$FRAMEWORKS" | jq -c '.[] | select(.app) | select(.app.measurements | map(.type) | contains(["clientSideRendered"]))' | while read -r framework; do
PKG=$(echo "$framework" | jq -r '.app.package')
echo "Building SPA for $PKG..."
echo "Building client-side rendered app for $PKG..."
(cd packages/$PKG && BUILD_MODE=spa pnpm build)
echo "Running SPA benchmark for $PKG..."
pnpm --filter @framework-tracker/stats-generator run:spa $PKG
echo "Running client-side rendered benchmark for $PKG..."
pnpm --filter @framework-tracker/stats-generator run:client-side-rendered $PKG
done

echo ""
echo "=== Running MPA benchmarks ==="
echo "=== Running server-side rendered benchmarks ==="
FRAMEWORKS=$(cat .github/frameworks.json)
echo "$FRAMEWORKS" | jq -c '.[] | select(.app) | select(.app.measurements | map(.type) | contains(["mpa"]))' | while read -r framework; do
echo "$FRAMEWORKS" | jq -c '.[] | select(.app) | select(.app.measurements | map(.type) | contains(["serverSideRendered"]))' | while read -r framework; do
PKG=$(echo "$framework" | jq -r '.app.package')
echo "Building MPA for $PKG..."
echo "Building server-side rendered app for $PKG..."
(cd packages/$PKG && pnpm build)
echo "Running MPA benchmark for $PKG..."
pnpm --filter @framework-tracker/stats-generator run:mpa $PKG
echo "Running server-side rendered benchmark for $PKG..."
pnpm --filter @framework-tracker/stats-generator run:server-side-rendered $PKG
done

echo ""
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ All frameworks are configured in `.github/frameworks.json`. Each entry specifies
"package": "app-astro",
"buildScript": "build:app-astro",
"buildOutputDir": "dist",
"measurements": [{ "type": "ssr" }]
"measurements": [{ "type": "ssrRequestThroughput" }]
}
},
```
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ USER node
WORKDIR /app
CMD [ "node", "src/cwv/index.ts" ]

FROM mcr.microsoft.com/playwright:v1.49.0-noble AS spa-benchmark
FROM mcr.microsoft.com/playwright:v1.49.0-noble AS client-side-rendered-benchmark
ENV PNPM_HOME="/pnpm"
ENV PATH="$PNPM_HOME:$PATH"
RUN npm install -g pnpm
Expand Down
Loading
Loading