fix: add rootDir to tsconfig.json#24
Merged
Merged
Conversation
43081j
approved these changes
Jun 10, 2026
Contributor
Author
|
FYI @43081j, the latest release being broken also breaks the e18e cli (when used via npx or equivalent at least). |
Contributor
|
I'm away right now but will cut a release soon as I'm at a laptop 👍 it is a shame ci didn't catch this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recently released version (0.2.1) has output files nested in
lib/src(see https://npmx.dev/package-code/@e18e/web-features-codemods/v/0.2.1/lib%2Fsrc%2Fmain.js), which breaks imports from the package.Building also gives this warning currently:
This PR sets the
rootDirto./src, which fixes the error and the output.That was a lot of text for a one line change :D