Remove access tokens from entgo #1357
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubno
force-pushed
the
remove-access-token-from-entgo-eng-3185
branch
2 times, most recently
from
ce1250e to
267b66c
Compare
jakubno
force-pushed
the
remove-access-token-from-entgo-eng-3185
branch
from
9d75dd9 to
af512a3
Compare
djeebus
reviewed
Oct 27, 2025
| @@ -0,0 +1,6 @@ | |||
| -- name: ValidateEnvBuilds :one | |||
There was a problem hiding this comment.
If we're not using the results, we might be able to swap this for :exec and just check for an error.
There was a problem hiding this comment.
It wouldn't return an error
djeebus
reviewed
Oct 27, 2025
Comment on lines
+38
to
52
| func ValidateAccessToken(ctx context.Context, db *client.Client, accessToken string) bool { | ||
| hashedToken, err := keys.VerifyKey(keys.AccessTokenPrefix, accessToken) | ||
| if err != nil { | ||
| return false | ||
| } | ||
|
|
||
| exists, err := db.AccessToken.Query().Where(accesstoken.AccessTokenHash(hashedToken)).Exist(ctx) | ||
| _, err = db.GetUserIDFromAccessToken(ctx, hashedToken) | ||
| if err != nil { | ||
| log.Printf("Error while checking access token: %s\n", err.Error()) | ||
|
|
||
| return false | ||
| } | ||
|
|
||
| return exists | ||
| return true | ||
| } |
There was a problem hiding this comment.
It'd be easy to get some tests around this, via testcontainers
djeebus
approved these changes
Oct 27, 2025
dobrac
reviewed
Oct 27, 2025
| if err != nil { | ||
| return false, err | ||
| } | ||
| if errors.Is(err, sql.ErrNoRows) { |
There was a problem hiding this comment.
there is a helper dberrors.IsNoRowsError
|
|
||
| e, err := db.Env.Query().Where( | ||
| env.ID(envID), | ||
| env.HasBuildsWith(envbuild.StatusEQ(envbuild.StatusWaiting)), |
There was a problem hiding this comment.
the status code filter is missing now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.